Improvements to Test Coverage #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kenny-MWI
changed the title
Kenny-MWI
changed the title
pdbreen
reviewed
Apr 15, 2021
| class AppliesToTest extends TestCase | ||
| { | ||
| /** @test */ | ||
| public function can_get_array_of_options() |
There was a problem hiding this comment.
This test (and the same test on LayoutType) should really be combined into a single test on BaseEnum since that's where the code lives. There's no code in the actual enums themselves. so really don't need a distinct test case for any of them once the base is covered.
There was a problem hiding this comment.
@Kenny-MWI Could you make this update in a new PR? I'm going to go ahead and merge this one.
pdbreen
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few small tests to slightly improve test coverage. I wanted to add tests for Events and the methods in the TipoffPackage.php file but I'm not sure about the best way to do those. I'm going to switch my efforts over to the packages in the priority list instead.
Here's the test coverage report for this PR:
Code Coverage Report: 2021-04-14 15:52:22 Summary: Classes: 32.14% (9/28) Methods: 52.21% (59/113) Lines: 65.68% (222/338) Tipoff\Support\Casts\DiscountableValue Methods: 100.00% ( 3/ 3) Lines: 100.00% ( 11/ 11) Tipoff\Support\Casts\Enum Methods: 100.00% ( 3/ 3) Lines: 100.00% ( 10/ 10) Tipoff\Support\Casts\Money Methods: 100.00% ( 3/ 3) Lines: 100.00% ( 8/ 8) Tipoff\Support\Enums\AppliesTo Methods: ( 0/ 0) Lines: ( 0/ 0) Tipoff\Support\Enums\BaseEnum Methods: 100.00% ( 2/ 2) Lines: 100.00% ( 6/ 6) Tipoff\Support\Enums\LayoutType Methods: ( 0/ 0) Lines: ( 0/ 0) Tipoff\Support\Events\BaseEvent Methods: ( 0/ 0) Lines: ( 0/ 0) Tipoff\Support\Events\Checkout\CartItemCreated Methods: 0.00% ( 0/ 1) Lines: 0.00% ( 0/ 2) Tipoff\Support\Events\Checkout\CartItemPurchaseVerification Methods: 0.00% ( 0/ 1) Lines: 0.00% ( 0/ 2) Tipoff\Support\Events\Checkout\CartItemRemoved Methods: 0.00% ( 0/ 1) Lines: 0.00% ( 0/ 2) Tipoff\Support\Events\Checkout\CartItemUpdated Methods: 0.00% ( 0/ 1) Lines: 0.00% ( 0/ 2) Tipoff\Support\Events\Checkout\CartUpdated Methods: 0.00% ( 0/ 1) Lines: 0.00% ( 0/ 1) Tipoff\Support\Events\Checkout\OrderCreated Methods: 0.00% ( 0/ 1) Lines: 0.00% ( 0/ 1) Tipoff\Support\Events\Checkout\OrderItemCreated Methods: 0.00% ( 0/ 1) Lines: 0.00% ( 0/ 2) Tipoff\Support\Events\Checkout\SellableEvent Methods: 0.00% ( 0/ 2) Lines: 0.00% ( 0/ 2) Tipoff\Support\Http\Controllers\Api\BaseApiController Methods: 100.00% ( 9/ 9) Lines: 100.00% ( 16/ 16) Tipoff\Support\Http\Controllers\BaseController Methods: ( 0/ 0) Lines: ( 0/ 0) Tipoff\Support\Http\Requests\BaseApiRequest Methods: 0.00% ( 0/ 5) Lines: 0.00% ( 0/ 20) Tipoff\Support\Models\BaseModel Methods: 53.85% ( 7/13) Lines: 40.91% ( 9/ 22) Tipoff\Support\Models\TestModelStub Methods: 100.00% ( 2/ 2) Lines: 100.00% ( 13/ 13) Tipoff\Support\Nova\BaseResource Methods: 0.00% ( 0/15) Lines: 0.00% ( 0/ 24) Tipoff\Support\Nova\Fields\Enum Methods: 0.00% ( 0/ 2) Lines: 0.00% ( 0/ 8) Tipoff\Support\Nova\Filters\EnumFilter Methods: 0.00% ( 0/ 4) Lines: 0.00% ( 0/ 7) Tipoff\Support\Objects\DiscountableValue Methods: 90.00% ( 9/10) Lines: 95.00% ( 19/ 20) Tipoff\Support\Rules\Enum Methods: 100.00% ( 3/ 3) Lines: 100.00% ( 4/ 4) Tipoff\Support\SupportServiceProvider Methods: 100.00% ( 4/ 4) Lines: 100.00% ( 16/ 16) Tipoff\Support\TipoffPackage Methods: 62.50% (10/16) Lines: 65.00% ( 26/ 40) Tipoff\Support\TipoffServiceProvider Methods: 66.67% ( 2/ 3) Lines: 96.77% ( 30/ 31) Tipoff\Support\Traits\HasCreator Methods: 0.00% ( 0/ 2) Lines: 0.00% ( 0/ 4) Tipoff\Support\Traits\HasPackageFactory Methods: 0.00% ( 0/ 1) Lines: 0.00% ( 0/ 4) Tipoff\Support\Traits\HasUpdater Methods: 0.00% ( 0/ 2) Lines: 0.00% ( 0/ 4) Tipoff\Support\Transformers\BaseTransformer Methods: ( 0/ 0) Lines: ( 0/ 0) Tipoff\Support\View\Components\Money Methods: 100.00% ( 2/ 2) Lines: 100.00% ( 6/ 6)