Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds initial contracts and events for Cart, CartItem and Sellable #60

Merged
merged 11 commits into from
Feb 24, 2021

Conversation

pdbreen
Copy link
Contributor

@pdbreen pdbreen commented Feb 23, 2021

This PR contains the working set of interfaces and events I've been using for carts and cart items. Its far enough along to look through and comment on, but I want to do a bit more hands on usage before removing the don't merge tag.

@pdbreen pdbreen marked this pull request as ready for review February 24, 2021 20:54
@pdbreen
Copy link
Contributor Author

pdbreen commented Feb 24, 2021

@drewroberts - I'm sure there may be some additional iteration on the interfaces (and the addition of interfaces for Order / OrderItem), but this is far enough along that its worth a merge if you like what you see.

In addition to the contracts and events, it includes a necessary fix in BaseModel so that morphTo() will work properly.

Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🛒

@drewroberts drewroberts merged commit 1a56e33 into main Feb 24, 2021
@drewroberts drewroberts deleted the pdbreen/feature/checkout-interfaces branch February 24, 2021 20:57
pdbreen pushed a commit that referenced this pull request Apr 8, 2021
drewroberts added a commit that referenced this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants