Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Order, OrderItem, Discount, Voucher and Booking interfaces and Order related events #63

Merged
merged 15 commits into from
Feb 25, 2021

Conversation

pdbreen
Copy link
Contributor

@pdbreen pdbreen commented Feb 25, 2021

Refactors common base interfaces for orders/carts and orderitems/cartitems - carts/cartitems are mostly a RW version of their RO order/orderitem counterparts.

@drewroberts drewroberts self-requested a review February 25, 2021 19:23
@pdbreen pdbreen changed the title Adds Order, OrderItem interfaces Adds Order, OrderItem, Discount, Voucher and Booking interfaces Feb 25, 2021
@pdbreen pdbreen changed the title Adds Order, OrderItem, Discount, Voucher and Booking interfaces Adds Order, OrderItem, Discount, Voucher and Booking interfaces and Order related events Feb 25, 2021
@pdbreen pdbreen marked this pull request as ready for review February 25, 2021 21:10
@pdbreen
Copy link
Contributor Author

pdbreen commented Feb 25, 2021

@drewroberts - this is good to go. Discount and Voucher interfaces don't yet introduce the extended support that was in notion, but they do support the existing discount / vouchers.

Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👯

@drewroberts drewroberts merged commit de06e0e into main Feb 25, 2021
@drewroberts drewroberts deleted the pdbreen/feature/order-interfaces branch February 25, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants