Add common support for API in packages #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 26, 2021 09:38
drewroberts
reviewed
Feb 26, 2021
src/TipoffPackage.php
Outdated
Comment on lines
61
to
77
| public function hasRoute(string $routeFileName): Package | ||
| { | ||
| if (config('tipoff.api.enabled')) { | ||
| return parent::hasRoute($routeFileName); | ||
| } | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| public function hasRoutes(...$routeFileNames): Package | ||
| { | ||
| if (config('tipoff.api.enabled')) { | ||
| return parent::hasRoutes(...$routeFileNames); | ||
| } | ||
|
|
||
| return $this; | ||
| } |
There was a problem hiding this comment.
Should these be hasApiRoute and hasApiRoutes to distinguish from the other routes the package may provide?
There was a problem hiding this comment.
Sure - we can do that. I'll add in config and methods for web routes at the same time. One sec.
drewroberts
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.