Add support for blade component registration in packages #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdbreen
commented
Mar 2, 2021
src/SupportServiceProvider.php
Outdated
| { | ||
| parent::bootingPackage(); | ||
|
|
||
| Blade::directive('tipoffMoney', function ($amount) { |
There was a problem hiding this comment.
@drewroberts - note the tipoff prefix on the directive registration. Seemed a bit aggressive to register a common term without some prefix.
…m:tipoff/support into pdbreen/feature/register-blade-components
…m:tipoff/support into pdbreen/feature/register-blade-components
|
Flagged as don't merge. Want to fix tmp dir issue when running tests on Windows before letting this in. |
|
Ok - this is good to go now. Unfortunately, the fix for the temp file issue in Windows Github action testing is both in this package and in test-support since this package can't pull in test support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.