Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SEO class aliases #21 #80

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Add SEO class aliases #21 #80

merged 3 commits into from
Mar 5, 2021

Conversation

chx2
Copy link
Contributor

@chx2 chx2 commented Mar 5, 2021

I realized when going back to TIPOFF/locations#55 , that none of the SEO classes were here. Added them in this PR.

@chx2 chx2 requested a review from drewroberts March 5, 2021 02:10
@drewroberts
Copy link
Member

We'll need to finish making Nova Resources for these models as well and add them to that section.

@@ -30,12 +30,16 @@

'company' => \Tipoff\Seo\Models\Company::class,

'company_user' => \Tipoff\Seo\Models\CompanyUser::class,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to reference this as a model since it is really just a pivot table.

Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎫

@drewroberts drewroberts merged commit bb84277 into main Mar 5, 2021
@drewroberts drewroberts deleted the chx2/feature/seo-aliases branch March 5, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants