Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to HasPackageFactory #16

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Change to HasPackageFactory #16

merged 1 commit into from
Feb 11, 2021

Conversation

pdbreen
Copy link
Contributor

@pdbreen pdbreen commented Feb 11, 2021

No description provided.

pdbreen
pdbreen commented Feb 11, 2021
View reviewed changes
src/Models/Tax.php

class Tax extends BaseModel
{
use HasFactory;
use HasPackageFactory;
Copy link
Contributor Author

@pdbreen pdbreen Feb 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, factory is not usable in other packages.

drewroberts
drewroberts reviewed Feb 11, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have someone go through and make these updates to every package.

drewroberts
drewroberts approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ➿

@drewroberts drewroberts merged commit fb054f4 into main Feb 11, 2021
@drewroberts drewroberts deleted the pdbreen/bugfix/has-package-factory branch February 11, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewroberts drewroberts drewroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdbreen @drewroberts