new General Code Rule: NO_CLASSES_SHOULD_USE_JODATIME

[sullis]

No description provided.

[sullis]

@codecholeric 👋 there is a build error in Travis CI. It appears to be 'executeRulesjava7junit4'

Can you review this?

[sullis]

Ready for review

[ghost]

DeepCode encountered a problem when analyzing this pull request. If you want to retry, create a comment: "Retry Deepcode".

[codecholeric]

Thanks for your contribution!! 😃
I've made a quick review commit, the Maven integration test still didn't run on my machine, since the scope didn't match (main code used DateTime).
Can you do me a favor and sign off your commits according to the DCO? (compare https://github.com/TNG/ArchUnit/blob/master/CONTRIBUTING.md#commits)
I think the easiest thing would be if you squash together all your commits and my commit (git rebase -i HEAD~10) and then sign off via git commit -s --amend, but feel free to do it any way you want 😉 (in the end your commits need those sign-off suffixes)

[hankem]

I'd actually use:

noClasses().should(USE_JODATIME).because("modern Java projects use the [java.time] API instead");

[codecholeric]

Yes, that actually is a good idea, I'll add that 😉

[thebpc]

Retry Deepcode

[ghost]

DeepCode analyzed this pull request.
There are no new issues.

[ghost]

DeepCode analyzed this pull request.
There are no new issues.

[sullis]

LGTM @codecholeric

[codecholeric]

Merged, thanks again for your contribution 😃

[sullis]

Yes! 😄 When is next release of ArchUnit?

[codecholeric]

Next release will be within the next couple of weeks I think 😉 Definitely want to put #38 in it...

[sullis]

@codecholeric any plans to release [archunit] this week? I am eager to start using the new JodaTime code rule.

[codecholeric]

I plan on doing it over the weekend. Writing another little enhancement and wanna give some time for a review on #38