Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation fixes #46

Merged
merged 6 commits into from
May 16, 2020
Merged

Documentation fixes #46

merged 6 commits into from
May 16, 2020

Conversation

hankem
Copy link
Member

@hankem hankem commented Jun 13, 2019

  • CONTRIBUTING.md:

    • The 'How to contribute' quick guide listed numbered steps from 2. to 7.
    • Creating a PR was mentioned in both the last two steps.
    • "The rules are pretty simple: if you can certify the below" was no sentence.

  • SystemPropertyValue annotation:

    • The Java Doc mentioned @EnvironmentVariableValue("property.key").

@hankem
reword contributing guidelines
bc44b76 
Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
@hankem
correct usage documentation of @SystemPropertyValue annotation
3e40fa7 
Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
@hankem
link each ValueExtractorProcessor's documentation to the correspondin…
b264506 
…g annotation

dropping the (obvious) ', implements ValueExtractorProcessor' part

Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
@hankem
eliminate JavaDoc warnings on missing parameter descriptions
a2d7473 
Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
@hankem
simplify BuilderConfiguration initialization
d438719 
Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
@hankem
update test dependencies (mockito, assertj)
886546f 
Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 98.413% when pulling 886546f on hankem:fix-documentation into 31633f0 on TNG:master.

@hankem hankem merged commit 65dc36d into TNG:master May 16, 2020
@hankem hankem deleted the fix-documentation branch August 21, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hankem @coveralls