Fixed click region for buttonwidget #408
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thnx! Have you checked this with a clickable legends inside the button and with the edit button active for dynamic layers? |
|
Ah die clicks worden dan inderdaad niet meer herkend... Ik zal kijken of ik een andere oplossing kan bedenken. |
|
Moved the click handling back to content, and adjusted the height and padding of the content so that it fills the entire div. I had to override the ng-binding and s3d classes padding for this, so it's using !important. |
|
@damylen do you think the pull request is acceptable now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click region for the button widget was only the content. Since the whole button widget area responds to mouseover, this is a bit counterintuitive, so I made the whole button widget area respond to clicks.