Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share Photometry #572

Merged
merged 76 commits into from
Jan 11, 2023
Merged

Share Photometry #572

merged 76 commits into from
Jan 11, 2023

Conversation

jchate6
Copy link
Contributor

@jchate6 jchate6 commented Oct 20, 2022

Allow for publishing photometry to Hermes or sharing directly with another TOM.

phycodurus and others added 26 commits September 24, 2022 01:02
@phycodurus
define and add a preliminary DATA_SHARING configuration dict
6620c5a
@phycodurus
add route to and draft impl of DataProductShareView
02a9e12
@phycodurus
add Publish button to items in dataproduct_list occurances
53aa87b 
Publish routes to the new DataProductShareView.
@phycodurus
flake8 compliance
a569703
@phycodurus
correctly formatting for hermes /submit endpoint
72a7084
@phycodurus
be more specific with DATA_SHARING configuration keys
3efa0c4
@phycodurus
preparation for TOM-TOM data sharing via REST API
26e6f04
@phycodurus
working draft of TOM-TOM sharing in share_with_tom()
e8eb592 
This is a draft version and works with TOM Toolkit-based TOMs
@phycodurus
query destination TOM for Target PK and handle responses
a055dd2
@phycodurus
clarify comment
b4c7257
@phycodurus
undoing this change that shouldn't have been commited
4bdbecb
@phycodurus
expand DATA_SHARING options and clean up conifg dict
4d8dff3
@phycodurus
mainly flake8 compliance; also stub out sharing_destination logic
f0eb86c 
submit_to_tom and submit_to_stream should probably be specified in
the DATA_SHARING configuration dict
@phycodurus
Merge branch 'dev' into feature/share-photometry
0a2222d
@phycodurus
if DATA_SHARING is not configured, don't offer to share data
318e6c5 
A list of data sharing destinations from settings.DATA_SHARING.keys()
should be in the context passed to the templates listing DataProducts.
If sharing_destinatinos evaluates to False the the Sharing UI should
not be presented.
@phycodurus
put sharing_destinations in the context for the DataProduct lists
2d8c997
@phycodurus
put sharing_destinations in the context for the DataProduct lists
905c429
@phycodurus
wip: handle MARS alerts that don't have magnitude as value dict key
42298ee 
'limit'-type Alerts should be handled as soon as we know what they
mean; awaiting an answer from an astronomer
@phycodurus
Merge branch 'feature/share-photometry' of https://github.com/TOMTool…
3af7ec6 
…kit/tom_base into feature/share-photometry
@phycodurus
remove code that got duplicated during a recursive, non-ff merge
e211d0c
@phycodurus
Mock-up a (non-functional) sharing UI for gathering feedback
368cd05
@phycodurus
clean out previous experimental sharing UI header/column
2d80290
@phycodurus
fix bug handling limit magnitudes in ZTF alert photometry
1b53ead
@jchate6
add dropdown form
814c3bb
@jchate6
add Dataproduct sharing form
5f920b2
@jchate6
get hermes submission working
85165d1
@jchate6 jchate6 marked this pull request as draft October 20, 2022 21:31
@jchate6 jchate6 changed the base branch from main to dev October 20, 2022 21:31
@jchate6
Copy link
Contributor Author

jchate6 commented Oct 22, 2022 •
edited
Loading

Sharing Datums:

  • get data for selected points in plot (selection event)
  • create form table with selected points
  • route form similar to data products form.

phycodurus
phycodurus reviewed Dec 15, 2022
View reviewed changes
tom_base/settings.py Outdated Show resolved Hide resolved
jchate6
jchate6 commented Dec 16, 2022
View reviewed changes
tom_dataproducts/views.py Outdated Show resolved Hide resolved
@jchate6 jchate6 marked this pull request as ready for review December 16, 2022 19:38
jnation3406
jnation3406 requested changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@jnation3406 jnation3406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few schema changes to make to line up with current hermes schemas.

docs/managing_data/customizing_data_sharing.rst Outdated Show resolved Hide resolved
tom_dataproducts/alertstreams/hermes.py Outdated Show resolved Hide resolved
tom_dataproducts/alertstreams/hermes.py Outdated Show resolved Hide resolved
tom_dataproducts/alertstreams/hermes.py Outdated Show resolved Hide resolved
tom_dataproducts/alertstreams/hermes.py Outdated Show resolved Hide resolved
tom_dataproducts/alertstreams/hermes.py Show resolved Hide resolved
tom_dataproducts/alertstreams/hermes.py Outdated Show resolved Hide resolved
tom_dataproducts/models.py Show resolved Hide resolved
tom_dataproducts/templates/tom_dataproducts/partials/dataproduct_list_for_target.html Outdated Show resolved Hide resolved
@jchate6 jchate6 merged commit be2bfdf into dev Jan 11, 2023
@jchate6 jchate6 deleted the feature/share-photometry branch January 11, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phycodurus phycodurus phycodurus approved these changes

@jnation3406 jnation3406 Awaiting requested review from jnation3406

Assignees

@jchate6 jchate6

Labels
enhancement New feature or request
Projects
TOM Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchate6 @phycodurus @jnation3406