Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix alias bugs #608

Merged
merged 5 commits into from
Feb 8, 2023
Merged

fix alias bugs #608

merged 5 commits into from
Feb 8, 2023

Conversation

jchate6
Copy link
Contributor

@jchate6 jchate6 commented Feb 7, 2023

I think this resolves all the weird issues with existing data.

And adds tests to that effect.

Closes #605

@jchate6 jchate6 added the bug Something isn't working label Feb 7, 2023
@jchate6 jchate6 marked this pull request as ready for review February 7, 2023 18:26
phycodurus
phycodurus approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@phycodurus phycodurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@jchate6 jchate6 merged commit af7e12e into dev Feb 8, 2023
@jchate6 jchate6 deleted the feature/alias_testing branch February 8, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phycodurus phycodurus phycodurus approved these changes

@jnation3406 jnation3406 jnation3406 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
TOM Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alias matching is causing bugs when updating target.
3 participants
@jchate6 @phycodurus @jnation3406