Rust interface #129
Merged
Rust interface #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing, thanks! Could you add installation instructions to the I am a bit concerned about adding this huge string with I see that Rust interface is released as 2.4.1 but there is no corresponding release of the TREXIO C API. I think it's important to keep them aligned. If you want, I can add Rust testing to the CI. |
|
OK, now the rust interface installs HDF5 and compiles trexio. We can merge :-) |
q-posev
reviewed
Oct 25, 2023
q-posev
reviewed
Oct 25, 2023
q-posev
reviewed
Oct 25, 2023
…ion_memo.txt to remember changes ;-)
|
Cool, thanks! So you want to keep the TREXIO JSON string in the C header for now? |
|
We can remove it if you don't like it, as i added it in the tar.gz release. Or we can also leave it as a comment in trexio.h
25 oct. 2023 12:34:34 Evgeny Posenitskiy ***@***.***>:
…
Cool, thanks! So you want to keep the TREXIO JSON string in the C header for now?
—
Reply to this email directly, view it on GitHub[#129 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABNRVYRKUJPXO5OQOMFK54LYBDTK7AVCNFSM6AAAAAA6NJ4WK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZYHE3TMMBUHE].
You are receiving this because you authored the thread.
[Image de pistage][https://github.com/notifications/beacon/ABNRVYTKXDYNL5VDJH3N5ATYBDTK7A5CNFSM6AAAAAA6NJ4WK6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTKBECTC.gif]
|
q-posev
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
rustdirectory I have put everything to build the Rust interface. I have uploaded it to Crates.io, so that when you docargo add trexio, you get trexio in your current working project:https://crates.io/crates/trexio
This package assumes that the C TREXIO library is installed on the system. I will also need to build a Rust crate that installs the TREXIO C library to make it fully functional.
To simplify building interfaces, I added to
trexio.hthe JSON config that produced it as astatic const char*variable. It avoids needing the trexio C source when building the interface.