Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using ISO_C_BINDING types in trexio_f.f90 #77

Merged
merged 7 commits into from
Jan 21, 2022
Merged

Using ISO_C_BINDING types in trexio_f.f90 #77

merged 7 commits into from
Jan 21, 2022

Conversation

scemama
Copy link
Member

@scemama scemama commented Jan 19, 2022

No description provided.

@plopezrios
Copy link
Collaborator

Isn't this all already in PR #74 ?

@scemama
Copy link
Member Author

scemama commented Jan 19, 2022

Most of it yes. But there are a few additional changes. We should first merge #74 and then see what is left.

plopezrios
plopezrios approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@plopezrios plopezrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments I've left in the code, this all looks good to me!

q-posev
q-posev approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@q-posev q-posev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @scemama ! Fine with me.

I mentioned a couple possible enhancements, but in principle this PR can be merged as is.

src/templates_front/build.sh Outdated Show resolved Hide resolved
src/templates_front/templator_front.org Outdated Show resolved Hide resolved
src/templates_front/templator_front.org Outdated Show resolved Hide resolved
@q-posev q-posev merged commit ba2e069 into master Jan 21, 2022
@q-posev q-posev deleted the iso_fortran_env branch May 18, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plopezrios plopezrios plopezrios approved these changes

@q-posev q-posev q-posev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scemama @plopezrios @q-posev