Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor & new analysis functions #3

Merged
merged 9 commits into from
Aug 18, 2020
Merged

Refactor & new analysis functions #3

merged 9 commits into from
Aug 18, 2020

Conversation

txie-93
Copy link
Collaborator

@txie-93 txie-93 commented Aug 18, 2020

  • Refactored the code. It now only reads the trajectory once. Significantly improved speed and memory use.
  • Several new analysis functions.

@txie-93 txie-93 self-assigned this Aug 18, 2020
Copy link
Collaborator

@danielschweigert-TRI danielschweigert-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Could you add a change related to a previous PR?
I want to make a small change to the keys in REQUIRED_METADATA:
'temperature' --> 'temperature_K' (unit Kelvin)
'timestep' --> 'time_step' (follows format of other keys, i.e. individual nouns separated by _)

I believe that also requires updating all of the meta.json files in the S3 folder. Hope this is easy to do.

@txie-93
Copy link
Collaborator Author

txie-93 commented Aug 18, 2020

I like your suggestions! Yes, it is easy to do. temperature_K looks a little odd though. We don't include units for other properties. Should I just change 'timestep' --> 'time_step'? @danielschweigert-TRI

@danielschweigert-TRI
Copy link
Collaborator

Sounds good to me. I am just worried that there could be confusion on the temperature unit; unless it's understood that K is the standard unit used.

@txie-93
Copy link
Collaborator Author

txie-93 commented Aug 18, 2020

Done! I updated both the code and the data. Merging the code now.

K is quite standard in my opinion, but this is a good point. Let's keep it as it is for now, and we can change in the future if we like.

@txie-93 txie-93 merged commit 65115ee into master Aug 18, 2020
@danielschweigert-TRI
Copy link
Collaborator

👍

@txie-93 txie-93 deleted the analysis_functions branch August 18, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants