Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 #126

Merged
merged 266 commits into from
Apr 4, 2024
Merged

v1.0.0 #126

merged 266 commits into from
Apr 4, 2024

Conversation

d-cogswell
Copy link
Collaborator

We've implemented a lot of major changes and it's time for a major release update. What else should be addressed first?

  • Add documentation for the new CCCVCPcycle profileType
  • Documentation updates for daetools installation
  • Should we switch back to the official daetools for testing since it has been updated?

loostrum and others added 30 commits April 26, 2021 12:25
…bardt from particle to interface, interface version of get_lyte_internal_fluxes and interface version of get_elyte_disc
Easy and not optimized code that allows to select vectors of parameters and make sequential simulations looping in them
@v1kko
Copy link
Collaborator

v1kko commented Sep 14, 2023

* Should we switch back to the official daetools for testing since it has been updated?

I agree with this. I can have a look tomorrow / next week, hopefully the changes to the workflow are simple and minimal :)

Adds an extra workflow which tests mpet with a newer daetools pulled from sourceforge
@v1kko
Copy link
Collaborator

v1kko commented Oct 2, 2023

I have added a regression tests with the newer daetools from sourceforge, I left the old ones in place as the one from sourceforge only seems to work with python 3.10 . ( it doesn't work out of the box and I don't have time to fix it).

Copy link
Collaborator

@v1kko v1kko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a regression testing which uses the sourceforge version of daetools, that part I now approve :)

@d-cogswell
Copy link
Collaborator Author

Development branch documentation is now automatically built here: https://mpet.readthedocs.io/en/development/

@d-cogswell
Copy link
Collaborator Author

@loostrum does it make sense to have dask and dash requirements as extras_require in setup.py?

@laurasootes
Copy link
Collaborator

laurasootes commented Oct 9, 2023

@loostrum does it make sense to have dask and dash requirements as extras_require in setup.py?

@d-cogswell, you are right, it makes more sense to move the dash and dask requirements to extras_require
also @loostrum

I made a PR to fix #128

@d-cogswell
Copy link
Collaborator Author

Thanks @laurasootes and @loostrum

stddev_c = self['stand_dev_contact']
mean_c = self['fraction_of_contact']

if 0 < mean_c < 1:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a check that this is only for solid electrolyte?

@@ -62,3 +62,5 @@ it is both tested as absolute and relative tolerance.
- test021: hdf5Fast file output and restarting hdf5 simulations
- test022: Test of specified_psd_c option, LFP homog
- test023: CIET for LFP
- test028: CCCVCPcycling for full cell with LIONSIMBA test file
- test029: CCCVCPcycling for half cell with LIONSIMBA test file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we adding any test cases for the solid electrolyte? and for the parallel jobs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test025 and test026 are for solid electrolyte (at least those are two we added). Let me know if you want me to add that to the tests readme file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test025 and test026 are for solid electrolyte (at least those are two we added). Let me know if you want me to add that to the tests readme file.

@loostrum updating the tests readme would be helpful if you don't mind.

@d-cogswell d-cogswell merged commit be680cb into master Apr 4, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants