v1.0.0 #126
v1.0.0 #126
Conversation
…config to separate section
…bardt from particle to interface, interface version of get_lyte_internal_fluxes and interface version of get_elyte_disc
…use interface region
Easy and not optimized code that allows to select vectors of parameters and make sequential simulations looping in them
d-cogswell
requested review from
loostrum,
lightningclaw001,
tammos,
alexandrosvasi,
Ombrini and
laurasootes
I agree with this. I can have a look tomorrow / next week, hopefully the changes to the workflow are simple and minimal :) |
Adds an extra workflow which tests mpet with a newer daetools pulled from sourceforge
|
I have added a regression tests with the newer daetools from sourceforge, I left the old ones in place as the one from sourceforge only seems to work with python 3.10 . ( it doesn't work out of the box and I don't have time to fix it). |
|
Development branch documentation is now automatically built here: https://mpet.readthedocs.io/en/development/ |
|
@loostrum does it make sense to have dask and dash requirements as |
@d-cogswell, you are right, it makes more sense to move the dash and dask requirements to extras_require I made a PR to fix #128 |
move dash and dask requirements to extras
|
Thanks @laurasootes and @loostrum |
| stddev_c = self['stand_dev_contact'] | ||
| mean_c = self['fraction_of_contact'] | ||
|
|
||
| if 0 < mean_c < 1: |
There was a problem hiding this comment.
should we add a check that this is only for solid electrolyte?
| @@ -62,3 +62,5 @@ it is both tested as absolute and relative tolerance. | |||
| - test021: hdf5Fast file output and restarting hdf5 simulations | |||
| - test022: Test of specified_psd_c option, LFP homog | |||
| - test023: CIET for LFP | |||
| - test028: CCCVCPcycling for full cell with LIONSIMBA test file | |||
| - test029: CCCVCPcycling for half cell with LIONSIMBA test file | |||
There was a problem hiding this comment.
are we adding any test cases for the solid electrolyte? and for the parallel jobs
There was a problem hiding this comment.
test025 and test026 are for solid electrolyte (at least those are two we added). Let me know if you want me to add that to the tests readme file.
There was a problem hiding this comment.
test025 and test026 are for solid electrolyte (at least those are two we added). Let me know if you want me to add that to the tests readme file.
@loostrum updating the tests readme would be helpful if you don't mind.
We've implemented a lot of major changes and it's time for a major release update. What else should be addressed first?