Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests #69

Merged
merged 11 commits into from
Aug 12, 2021
Merged

Regression tests #69

merged 11 commits into from
Aug 12, 2021

Conversation

d-cogswell
Copy link
Collaborator

@d-cogswell d-cogswell commented Aug 3, 2021

-Addresses issues with regression tests failing on different computers or after trivial changes to equations.
-Adds noise to regression tests with LFP and multiple particles per volume
-Changes noise so that it is added to overpotential for homogeneous models, or mu for the solid diffusion models
-Significantly improved noise interpolation performance

@@ -31,7 +31,7 @@
},
"activity": {
"printHeader": "false",
"printStats": "false",
"printStats": "true",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we setting printStats to true again?

Copy link
Collaborator Author

@d-cogswell d-cogswell Aug 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, printStats is disabled after the daetools_config_options.txt is written so it shows up as "true".

@lightningclaw001
Copy link
Collaborator

seems to work! I tried adding a new variable with dXdt = 0, and all the tests pass now. Also dXdt = a nonzero value breaks all of the tests, so this seems to be good to me!

@d-cogswell d-cogswell marked this pull request as ready for review August 10, 2021 19:27
@d-cogswell d-cogswell merged commit 0875f3d into development Aug 12, 2021
@d-cogswell d-cogswell deleted the regression_tests branch August 12, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Case Results Not Convergent test022 succeeds on github actions but fails on my machines (Mac / CentOS)
2 participants