Regression tests #69
Merged
Regression tests #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 3, 2021
max error against tolerance.
from triggering phase-separation.
d-cogswell
force-pushed
the
regression_tests
branch
from
40e5cda
to
4d87b67
Compare
performance improvement.
| @@ -31,7 +31,7 @@ | |||
| }, | |||
| "activity": { | |||
| "printHeader": "false", | |||
| "printStats": "false", | |||
| "printStats": "true", | |||
There was a problem hiding this comment.
are we setting printStats to true again?
There was a problem hiding this comment.
Weird, printStats is disabled after the daetools_config_options.txt is written so it shows up as "true".
|
seems to work! I tried adding a new variable with dXdt = 0, and all the tests pass now. Also dXdt = a nonzero value breaks all of the tests, so this seems to be good to me! |
d-cogswell
force-pushed
the
regression_tests
branch
from
cee8d9a
to
853b53c
Compare
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Addresses issues with regression tests failing on different computers or after trivial changes to equations.
-Adds noise to regression tests with LFP and multiple particles per volume
-Changes noise so that it is added to overpotential for homogeneous models, or mu for the solid diffusion models
-Significantly improved noise interpolation performance