[h5] Store additional member variables when storing solver object #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TRIQS#115 -Store additionally the following members: h_diag, _h_loc, _density_matrix, _average_sign, _solve_status, Delta_infty_vec -TODO: move the histogram members pert_order, pert_order_total and performance_analysis into the container_set class as std::optional and add them to the corresponding h5_read/h5_write
HugoStrand
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Dear Nils,
Thank you for the pull request! and for the nice h5_try_read() helper function. This should solve some of the headaches of storing cthyb to h5.
(Unfortunately the python layer of the solver still adds additional member parameters that are not stored when serializing to h5, but I do not know how to solve that.)
I am merging this.
Cheers, Hugo
| @@ -52,7 +52,7 @@ namespace triqs_cthyb { | |||
| h5_read(grp, "G_tau", c.G_tau); | |||
| h5_read(grp, "G_tau_accum", c.G_tau_accum); | |||
| h5_read(grp, "G_l", c.G_l); | |||
| if( grp.has_key("O_tau") ) h5_read(grp, "O_tau", c.O_tau); | |||
| h5_try_read(grp, "O_tau", c.O_tau); | |||
There was a problem hiding this comment.
Thank you! This helper function is very very nice! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Store additionally the following members together with the solver object
h_diag, _h_loc, _density_matrix, _average_sign, _solve_status, Delta_infty_vec
-TODO: move the histogram members pert_order, pert_order_total
and performance_analysis into the container_set class as std::optional
and add them to the corresponding h5_read/h5_write
This PR fixes Issue #115