Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: range checking for cmake find_package #921

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: range checking for cmake find_package #921

merged 1 commit into from
Oct 3, 2023

Conversation

thenoursehorse
Copy link
Contributor

Fixes #920.

I have not included a test to show that the version checking works. I can write up a mock c++ project and attach if necessary.

Wentzell
Wentzell approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@Wentzell Wentzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @thenoursehorse for this fix!

@Wentzell Wentzell merged commit c928350 into TRIQS:unstable Oct 3, 2023
1 check passed
@Wentzell Wentzell mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wentzell Wentzell Wentzell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thenoursehorse @Wentzell