Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ttt_quickslot #1025

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix ttt_quickslot #1025

merged 1 commit into from
Mar 7, 2023

Conversation

ruby0b
Copy link
Contributor

@ruby0b ruby0b commented Mar 7, 2023

ttt_quickslot did not work previously.
QuickSlot wrongly tried to convert the args table to a number.
There was also a mix up between slots and weapon kinds: The current weapon kind is already the same as the displayed number, no need to subtract 1 from user input.

@ruby0b ruby0b temporarily deployed to histalek-dev-env March 7, 2023 15:31 — with GitHub Actions Inactive
Copy link
Member

@Histalek Histalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding! This was seemingly broken for a loooong time :D

Confirmed broken on v0.11.6b and confirmed fixed by this PR

Copy link
Member

@saibotk saibotk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your efforts ☺️

@saibotk saibotk merged commit 629535a into TTT-2:master Mar 7, 2023
@ruby0b ruby0b deleted the fix-quickslot branch March 7, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants