-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add files for MakeTextEntry #1039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really have experience with vgui stuff so i can't really give a proper review on that part. So i'll stick with more general stuff.
Besides addressing my direct comments please also do the following:
- remove commented out code
- remove multiple empty lines (there should only be a single empty line at most)
- double-check the comments, many of them reference a searchbar which doesn't really match the proposed feature of a textarea :D
gamemodes/terrortown/gamemode/client/cl_vskin/vgui/dform_ttt2.lua
Outdated
Show resolved
Hide resolved
gamemodes/terrortown/gamemode/client/cl_vskin/vgui/dform_ttt2.lua
Outdated
Show resolved
Hide resolved
gamemodes/terrortown/gamemode/client/cl_vskin/vgui/dtextentry_ttt2.lua
Outdated
Show resolved
Hide resolved
Oops! Overlooked some things, I disabled all the code that shimmed this stuff in from one of my addons, but not the other. The time between reloading the whole gamemode and the F1 menu had me not wanting to touch anything else once it was running since a bad reload on the F1 menu prompted a flashing white panel. Hopefully this cuts it down to just the bare bones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codestyle looks good now, thanks!
Don't forget to add an entry to the Changelog :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much 🙏
Small note: For future PRs please do not resolve conversations on your own, because we have established this as a rule to only let the reviewer close that when they think everything is resolved as they intended. Just because miss understandings happen frequently.
But again Thanks especially for also including a picture 👌
the people, they need strings