Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loadingscreen: Added Screen on Round Restart #1524

Merged
merged 22 commits into from
May 25, 2024
Merged

Loadingscreen: Added Screen on Round Restart #1524

merged 22 commits into from
May 25, 2024

Conversation

TimGoll
Copy link
Member

@TimGoll TimGoll commented May 22, 2024

This PR is not as big as it looks, this is only because I modified the tips strings in all languages!

This pullrequests adds a loadingscreen that hides the visible and audible lag introduced by the map cleanup on round change. This is done because the lag can hardly be improved since it all takes place in game.CleanupMap. It can be disabled if one dislikes it.

This PR also moves the (in my opinion annoying) tips panel to a more useful place by displaying those tips on the new loading screen.

loadingscreen.mp4

Settings panel to disable loading screen and tips:

image

Note: The tips convar is carried over from the original TTT convar.

@TimGoll TimGoll added this to the v0.14.0b milestone May 22, 2024
@TimGoll TimGoll added the type/enhancement Enhancement or simple change to existing functionality label May 22, 2024
@TimGoll TimGoll marked this pull request as ready for review May 22, 2024 15:30
lua/ttt2/libraries/loadingscreen.lua Outdated Show resolved Hide resolved
gamemodes/terrortown/gamemode/client/cl_tips.lua Outdated Show resolved Hide resolved
@TimGoll
Copy link
Member Author

TimGoll commented May 23, 2024

I'm leaving this one open as it is a bit bigger so that there is a chance for someone else to take a look at it

@TimGoll TimGoll merged commit 1b6b779 into master May 25, 2024
4 checks passed
@TimGoll TimGoll deleted the loadingscreen branch May 25, 2024 12:12
TimGoll added a commit that referenced this pull request May 25, 2024
Merge after #1524

In an effort to reduce the spam in the mstack at round begin, I removed
these two messages. They add no important information to the game and
are kinda redundant.


![image](https://github.com/TTT-2/TTT2/assets/13639408/917be0d6-9a91-483f-91a4-751f29f87e32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement or simple change to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants