Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify street names #6

Merged
merged 5 commits into from
Feb 25, 2020
Merged

Identify street names #6

merged 5 commits into from
Feb 25, 2020

Conversation

TTitcombe
Copy link
Owner

This PR:
Extends checks for addresses to include a simple street name:

  • A house number of up to four digits (characters are not included in this PR, e.g. 221B)
  • A street name of up to 10 characters
  • A suffix, one of "road", "street", "avenue", "way"

To test:
Unit tests have been included

Fixes partially #3

@TTitcombe TTitcombe added the enhancement New feature or request label Feb 25, 2020
@TTitcombe TTitcombe added this to the 0.1.0 milestone Feb 25, 2020
@TTitcombe TTitcombe merged commit 10176fc into master Feb 25, 2020
@TTitcombe TTitcombe deleted the identify_street_names branch February 25, 2020 09:51
@TTitcombe TTitcombe mentioned this pull request Feb 26, 2020
Closed
@TTitcombe TTitcombe mentioned this pull request Mar 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@TTitcombe