[SSR-1] Removal of Rendertron #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
added
feature
Closed
|
Given that Rendertron is
I have decided to roll out this chage immediatly, without waiting for me to be able to provide a PR which fixes this issue properly (it will come, but nessesary work seems larger than expected) |
CommanderStorm
added a commit
that referenced
this pull request
Apr 1, 2023
This reverts commit 7b58985.
CommanderStorm
added a commit
that referenced
this pull request
May 26, 2023
* integrated #355 Applied the fixes from the Maplibre migration added a editorconfig file for more consistent lints migrated from swagger-codegen's types to openapi-typescript added the vite-plugin-rewrite-all dependency, as a workaround for vitejs/vite#2415 This will be solved if vitejs/vite#2634 is merged migrated 1f050e8 stopped eslint from fixing .js files due to a suspeced infinite loop updated some of our js-dependencys to the newest version. No changes required adapted the webclient for the new version of our API docs migrated vite to v4.x fixed bug of v-for and v-if not being separated fixed how the DetailsView and the feedbackButton are coupled added an alt tag for a thumb-building fixed thumb-building preview not having the correct path set our npm type to module to prevent import errors renmoved unneeded defineExpose import rebase of d2b2a1d rebase 5e2f141 rebase 31f34b4 rebase of 61b8cd3 rebase of 2c1a33a updated swagger codegen Fixed defineExpose being used twice press `/` to focus the search bar (#270)* press / to focus the search bar removed legacy file Try to fix the share menu not opening on Safari (#269) migrated to the new docs style Remove API lang cookie (#259)* Remove checking the cookie in the server * Fix language determination in the webclient * Remove cookie from API documentationCo-authored-by: Frank Elsinga <frank@elsinga.de> Darkmode lang/theme selector (#256)* Switched the disabled lang/theme selector color to whiteCo-authored-by: octycs <git@octycs.eu> Separated Coordinate Handling (#243)* seperated coordinates and other data from each other * improved how entries are formattedCo-authored-by: octycs <octycs@users.noreply.github.com> Fixed the room feedback not being correctly interpreted by GitHub mapbox migrated the vue3 webclient to nav.tum.de Link to the calendar (#221)* implemented a link to the calendarCo-authored-by: octycs <octycs@users.noreply.github.com> Changed user location dot color to #3070B3 (#233)Co-authored-by: ge78fug <ge78fug@mytum.de> added the outdatedBrowser detection hacked together the linking between the feedbackbutton and the interactive map fixed issues preventing the feedback modal to open properly improved the typing in the interactive map changed the localStorage access key for storing feedback-coordinates to be more in line with the other usage `feedback-token` fixed some of the feedback related functionality in other parts of our app merged all feedback related functionality into its own component set mapboxgl and swaggerui to be manually chunked set mapboxgl to be manually chunked seperated swagger-ui-dist from the api view for inital page loads fixed vite not correctly routing /api/ fixed details not correctly registering navigation events fixed roomfinder maps not being loaded correctly replaced existance checks via a && a.b with a?.b replaced v-on:click with @click fixed interactive maps button not being correctly highlighted fixed loading icon not disapearing misteriously on the details screen inlined a bracket into the translation fiede how referencing between the map componentand the DetailsView.vue worked added rsync as an docker dependency added a script, which builds the needed files for our deployment increased the cache duration of the assets folder moved everything that can be cached into the assets folder clairified the theme selector modived the nginx config for the adapted deployment inital draft of the updated docs fixed bug, where early returning after redirection lead to invalid content being shown moved files around for uniformer layout inlined loadMap() fixed a translation not working due to a typo fixed the map not working due to wrong paths fixed other typing issues fixed wrong usage of the translation api migrated the details view to the composition API added v-if check for sources being present extracted the feedbackbutton into its own component moved confirmLocationPicker and other related functionality to he interactive map fixed the details routing unified the Showcase naming to Slideshow fixed bug in copyCurrentLink method declartion extracted the roomfinder into a seperate component sources extracted the sources into a seperate component extracted the InfoSection into its own component extracted the (currently unused) featured section into an own component extracted the building overview and the room overview into its own component fixed typing issues in the auto-generated typing stubs split the interactive map into its own component added the type keyword to an type-only import switched from a home-grown reset function to a buildin function for the details store migrated the error.msg to an pinia store, for accessing the erroer it in the useFetch method fixed import of mapboxgl in the interactive-map migrated usages of `==` to `===` unified the translation formatting previously, the existance of a leading newline and a trailing space was possible removed scoped stylesheets, as it was noticed, that they cause weird styling issues removed an v-if statement without any effect in vue3, this v-for statement is apparently illegal and needs a wrapper inlined some functions from autocomplete.ts, as they were only used in the searchbar added active to the acitve toggler in the settings at the bottom moved the the scss components to their respective owners moved our noscript warning to our index.html moved the seachbar to its own component fixed, that the design of the language toggler was different to currently deployed fixed the SearchView.vue not being rendered correctly fixed issue of some translation blocks having a trailing whitespace reverted change to change copied in the calller and instead changed this state in the called method fixed the success not being correctly indicaded in copyCurrentLink() fixed places, where translation was incorrectly used refactored the details-state to live in pinia fixed setDescription and setTitle being used in the new waypreviously, this was done via the global variable "navigatum" refactored the sharebutton into its own component reconfigured the dockerfile for the new build system moved our logo to the assets folder to enable automatic inlining moved removeLocalStorage,setLocalStorageWithExpiry,getLocalStorageWithExpiry to utils/storage added configuration option to explicitly tell vite, that we are a spa added the ability to view our about pages configured environment options and api proxying removed the preconnect statements and explicit theming changed the internal name of the details api, to not confuse people between GET and get fixed an import bug in the search view made the language selection persistent made the openapi.yaml server from the actual host, instead of github fixed origin check to allow local-remote development added typing to the fetch options. added the credentials handling seen in #198 fixed faulty inlinging of more() and less() unified the language and theme selectors in their own components added swagger codegen for typescript types fixed our localisation by migrating to unplugin-vue-i18n changed the i18n options to what we want fixed another path issue with paths not being found renamed router-link to RouterLink, as this is recomended moved the main template to app.vue fixed an issue with locale templates in html partialy migrated about, details and search migrated the main view to vue3 moved interactive-map.ts to typescript moved scss to the index.html for faster time to design removed legacy code.js removed unused components from the template migrated feedback to ts converted modules to ts modules changed how comments in our scss work reodered the package.json added i18n migrated the apiview to vue3 fixed an pathing issue moved our utils to a comon directory moved all styles to be consistently below the html changed all paths to the assets to @asset removed unnessesry app prefix fromatting re-enabled some imports from the previous dockerifle removed old build system scss move vueI18n removed polyfills temporarily to focus on making the app work moved views 1:1 into single file components moves added our old routing config moved the 404 and api view to a SFC moved more files to different directories moved some files to a new directory added the basic vue3 template * made shure that the feedback and the calendar APIs route to our servers * fixed the General message modal throwiing an error if no information_modal is supplied * fixed typing bugs * rebased #4149cc0f680c48f689172cea6b0c861f970990d4 * fixed deployment issues * [SSR-1] Removal of Rendertron (#474) Remvoal of Rendertron * typing fixes * linting fixes * fixed links not being able to be copied * linting fixes * fixed html content in translations not being displayed properly * linting fixes * fixed one translation * translation fixes * renamed methods in the browser detection * added the canonical link to the html to make shure chrome is not confused about our stagings * Migrate new POI URL * Fix a bug where the map would not update when updating the DetailsView * migrated ##502 * migrated #532 * Change arguments for scrolling (still sometimes not working properly yet) * migrated the addition of the TUM logo * updated the api_types and ran the linter * fixed default thumbnails not being displayed and not being localised * fixed the api view not being correctly linked to * added the openapi definition to the cdn to correctly load the api page * made the app reload on theme/language change fixing this not applying * fixed the window continuously reloading * fixed the about view not being reflective of the actual url being used currently * fixed the details view being stuck loading for an unnessesaryly long time * fixed small design issues in the feedback modal * added debug information to the language toggler * added VITE_APP_URL to the environent variables * tested a diffferent approach to introduce VITE_APP_URL into the webclient * maybe fixed the cookies not loading properly? * renamed utils to composables * added a saveCooke() function to centralise this functionality * aded an debug alert * removed alert * tested a different way to scope cookies * removed logging statements from the code * uptated the typescript bindings for the openapi spec * bumped our linting suite and `swagger-ui` * bumped maplibre to v3 as in master * Add resizeObserver to scroll to y-positions > 0 on forward/backward navigation. The problem is that the scroll is intiated before the components are updated. If the previous page was shorter than the next one, the browser might not scroll then. I am not sure exactly why this breaks now and didn't break in the vue2 version, but I think it is because Vue router is now async. The solution with a resizeObserver requires the least changes. Else we would need to add scrolling code to all views. * added translations to the search and general feedback button `aria-label`'s --------- Co-authored-by: octycs <git@octycs.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR in the #473 commit series
(this can be merged immediatly, or after merging other SSR PRs into this PR)
Proposed Changes (include Screenshots if possible)
How to test this PR
/
How has this been tested?
/
Checklist: