Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New Interface #12

Closed
wants to merge 8 commits into from
Closed

[WIP] New Interface #12

wants to merge 8 commits into from

Conversation

sebhahn
Copy link
Member

@sebhahn sebhahn commented Apr 28, 2019

New interface based on several classes. It allows to access individual files (IsmnFile) or a collection of files (IsmnFileCollection). Furthermore, a file collection can be converted into a nested structure of Networks, Stations and Sensors. This way it is straight forward to iterate over individual networks/stations/sensors/depths/etc.

  • Finish documentation
  • Finish tests
  • Add support for static information
  • Add support to store/load metadata information

@coveralls
Copy link

coveralls commented Apr 28, 2019

Coverage Status

Coverage increased (+2.4%) to 72.351% when pulling f4ffaf4 on sebhahn:interface2 into c44dea5 on TUW-GEO:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 69.962% when pulling db65562 on sebhahn:interface2 into da9cdca on TUW-GEO:develop.

@wpreimes
Copy link
Member

wpreimes commented Jun 12, 2019

I think it would be a nice feature if there was a function that returns the citation information for the currently loaded ISMN networks as a Latex table. Basically every network object could include a load_citation function or something similar and the interface could iterate over all networks to collect the needed information and merge them into a table. Is the citation info only on the website or can we read it also from the metadata directly? What do you think? I could help with that if you want.

@sebhahn
Copy link
Member Author

sebhahn commented Jun 12, 2019

Feel free to add this feature

@wpreimes wpreimes mentioned this pull request Jan 27, 2021
@wpreimes
Copy link
Member

wpreimes commented Jun 1, 2021

Has been included in v1.0. Therefore closing this issue

@wpreimes wpreimes closed this Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants