Change argument names for metrics functions #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in previous versions input parameters for metrics were called observations and predictions, which is misleading as the order of the arguments for the metrics does not matter, and for the bias function the old argument order lead to confusion as the order of the subtraction was contradicting general agreements.
|
this should fix #138 |
|
I'm fine with that. @sebhahn Any comments? |
|
Looks good. However, I'd rather prefer another description of E.g. instead of |
|
Done |
|
👍 |
|
Now the bias is different from the rest. Was that on purpose? |
|
oops, no, I will change it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the names for metrics input data to general names (
xandyinstead ofoandp), so the bias function can not be misinterpreted anymore.