-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in indexing when interpolate leapday was set #217
Conversation
If input data is less than 1 year then this failed because it tried to index days that did not exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@wpreimes Do you have any plans for a next release. I've seen quite a lot of stuff happening lately. I fixed this hoping we could make a bugfix release quite soon since this is holding us back. If you don't have any problems with it I can also tag a release so it is not work for you. |
The plan was to go for a release by the end of this week. I would like to run a few validations with the updated metrics first. But if it is really urgent I can also do the release now, and if really necessary we could release another fix this week. @s-scherrer your changes are now all in the master, right? |
Yes, the PRs I opened are all merged. I'm still working on the updated metrics calculators, but this might take a few more days. Releasing now is fine with me. |
I can also put my commit into a hotfix branch and just release 0.9.1. Then we can do a larger release when you are ready. |
ok, I think thats better. 0.10.1 would be the new version |
Yes. just saw 0.10.1. I can make that on a |
If input data is less than 1 year then this failed because it tried to index days that did not exist
Pushed the branch, updated the changelog and will tag as v0.10.1 |
the |
Yes. I've seen the new CI pipeline using Github Actions. It's nice. I've uploaded the windows wheels and the tar.gz file since the linux wheels are not compatible with pypi at the moment. If I understood correctly. |
yes. thanks |
If input data is less than 1 year then this failed because it tried to index
days that did not exist