[BUGFIX] Load only LIVE records in checkIfPageIsHidden #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `checkIfPageIsHidden` queries the page and afterwards performs the workspace overlay. However the first query can also load workspaced records, because the restriction is missing, which means changes in the workspace can affect the preview functionality of LIVE. Most of the times this won't break, because of the `LIMIT 1` and normally in the database the WS records will be stored after the LIVE record. We first identified this bug in TYPO3 v10, where this bug is in `TypoScriptFrontendController`: https://github.com/TYPO3/typo3/blob/11.5/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php#L852 There you can see there is a check for `pid > 0` in the query which is the legacy way of saying "no workspace version".
|
Thank you for your contribution to TYPO3. We are using Gerrit Code Review for our contributions and took the liberty to convert your pull request to a review in our review system. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
checkIfPageIsHiddenqueries the page and afterwards performs the workspace overlay.However the first query can also load workspaced records, because the restriction is missing, which means changes in the workspace can affect the preview functionality of LIVE.
Most of the times this won't break, because of the
LIMIT 1and normally in the database the WS records will be stored after the LIVE record.We first identified this bug in TYPO3 v10, where this bug is in
TypoScriptFrontendController: https://github.com/TYPO3/typo3/blob/11.5/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php#L852There you can see there is a check for
pid > 0in the query which is the legacy way of saying "no workspace version".