Add more cursor movements #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
May 15, 2022 21:03
Most of the input logic was duplicated in three places as of now: * Database filter input * SQL Editor * Table filter This is done in preparation for adding more cursor movement functionality for inputs.
<Ctrl-w> deletes the input from the current cursor position up to the first occurence of a whitespace before the current position.
The database tree was updated for the filter string of the previous key press before. This became more apparent with the new movements like 'delete word' (Ctrl-w).
This deletes in the left direction until a non alphanumeric character is found.
This makes UX much smoother IMHO. The filter focus is now moved back to the tree by pressing <Esc> while in filtering mode.
Move backwards until first non alphanumeric occurence.
Until the next occurence of a nonalphanumeric char.
Until a non alphanumeric char.
To be more consistent with wording.
|
Sorry for the late review. I will review when I have time. |
Hey, no worries and thanks for taking the time! From my point of view it is pretty complete now. |
sebashwa
commented
May 23, 2022
| self.focus = Focus::Tree; | ||
| return Ok(EventState::Consumed); | ||
| } | ||
| Key::Ctrl('j') | Key::Ctrl('n') => { |
There was a problem hiding this comment.
Not sure if this is a desired change at all and wether we should take custom key bindings into account?
| @@ -69,6 +69,7 @@ pub enum Key { | |||
| Char(char), | |||
| Ctrl(char), | |||
| Alt(char), | |||
| AltBackspace, | |||
There was a problem hiding this comment.
I'm sure this can be done in a more elegant way like Alt(Key::Backspace)? But I couldn't wrap my head around this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
thanks for creating this app, I like it a lot! I thought it might make sense to provide more cursor movement / input editing keybindings. To start with Ctrl-w (word deletion) seemed useful to me in order to delete i.e. a database filter query quickly.
Following changes are included in this PR so far:
Any feedback (especially concerning the refactoring) very welcome, as I am not super proficient writing Rust so far.
sebashwa