-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tabby-eval
package to run e2e evaluation on modal
#893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
Please also fix the semantic pr lint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this file
from modal import Image, Mount, Secret, Stub, asgi_app, gpu, method | ||
from pathlib import Path | ||
from typing import Union, List, Optional, Any, Tuple | ||
#from modal.tabby_python_client.models.health_state import HealthState |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#from modal.tabby_python_client.models.health_state import HealthState |
) | ||
from tabby_python_client.types import Response | ||
from tabby_python_client import errors | ||
import pandas as pd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move python/tabby/tabby-data-pipeline
to python/tabby-eval
tabby-eval
package to run e2e evaluation on modal
add modal folder, including tabby_python_client folder and predict.py