Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tabby-eval package to run e2e evaluation on modal #893

Merged
merged 6 commits into from
Nov 25, 2023

Conversation

yan91083
Copy link
Contributor

add modal folder, including tabby_python_client folder and predict.py

@wsxiaoys wsxiaoys marked this pull request as ready for review November 25, 2023 02:00
Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

Please also fix the semantic pr lint.

Copy link
Member

@wsxiaoys wsxiaoys Nov 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

from modal import Image, Mount, Secret, Stub, asgi_app, gpu, method
from pathlib import Path
from typing import Union, List, Optional, Any, Tuple
#from modal.tabby_python_client.models.health_state import HealthState
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#from modal.tabby_python_client.models.health_state import HealthState

)
from tabby_python_client.types import Response
from tabby_python_client import errors
import pandas as pd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

Copy link
Member

@wsxiaoys wsxiaoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move python/tabby/tabby-data-pipeline to python/tabby-eval

@yan91083 yan91083 changed the title Modal script feat: Modal script Nov 25, 2023
@wsxiaoys wsxiaoys changed the title feat: Modal script feat: add tabby-eval package to run e2e evaluation on modal Nov 25, 2023
@wsxiaoys wsxiaoys merged commit 39962c7 into TabbyML:main Nov 25, 2023
1 check passed
@yan91083 yan91083 deleted the modal-script branch November 25, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants