Skip to content
This repository has been archived by the owner on Dec 19, 2022. It is now read-only.

node 10 support (part 1) #37

Merged
merged 5 commits into from
Jan 31, 2019
Merged

Conversation

deancouch
Copy link
Collaborator

@deancouch deancouch commented Jan 30, 2019

  • use the new Buffer constructors Buffer.alloc and Buffer.from
  • fix the range of values generated for the writexxx tests to now better match the signed / unsigned functions
  • copy the node 8 functions (https://github.com/nodejs/node/blob/v8.x/lib/buffer.js) into the reader / writers and use these (note we may need to include the copyright notice)

This allows us to release a non-breaking change that is compatible with node 8 and node 10.

part 2 will be a breaking change and include:

  • switching back to the real node Buffer.writexxx / Buffer.readxxx functions
  • remove the noAssert functionality
  • bump ref to 1.3.5

@deancouch deancouch merged commit b0eb813 into Tabcorp:master Jan 31, 2019
@deancouch deancouch deleted the node10-buffers branch January 31, 2019 03:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants