Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various QOL changes #297

Merged
merged 5 commits into from
Mar 1, 2021
Merged

Various QOL changes #297

merged 5 commits into from
Mar 1, 2021

Conversation

mttk
Copy link
Member

@mttk mttk commented Feb 26, 2021

  • Enable retrieving a Field from a Dataset by its name.
    • Motivation: we're using a built-in dataset (HF or Podium) and we want to get the Vocab of a specific Field. Currently, we have to rely on list ordering, now we can reference by name.
  • Enable custom matrix type for batches
    • Now you don't have to cast every numpy array to torch, etc. You can pass a callable (which can also put the array on gpu etc).
    • Should look into making this a bit cleaner, e.g. via a decorator for iterators?
  • Document dataset.split in rst
  • Document dataset.concat in rst

docs/source/advanced.rst Outdated Show resolved Hide resolved
docs/source/advanced.rst Outdated Show resolved Hide resolved
docs/source/advanced.rst Outdated Show resolved Hide resolved
docs/source/advanced.rst Outdated Show resolved Hide resolved
docs/source/advanced.rst Show resolved Hide resolved
podium/datasets/dataset.py Show resolved Hide resolved
podium/datasets/iterator.py Show resolved Hide resolved
podium/datasets/iterator.py Show resolved Hide resolved
Copy link
Collaborator

@FilipBolt FilipBolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mttk mttk merged commit 1669283 into master Mar 1, 2021
@mttk mttk deleted the qol_fixes branch March 1, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants