Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [MDB IGNORE] [MDB IGNORE] You can have your cake and eat it too. Remake of #66406 (Splitting up areas.dmi + code related stuff) #672

Merged
merged 7 commits into from
May 9, 2022

Conversation

TaleStationBot
Copy link
Contributor

Original PR: tgstation/tgstation#66726

About The Pull Request

Remake of #66406 because a merge got fucked up and I didn't know how to rectify it.

Why It's Good For The Game

This PR is mostly coder facing, but any bugs that arise will be player facing.

All this does is slice areas.dmi into multiple, smaller files. This makes navigating area turfs much more friendly and easy, instead of combing the behemoth that was 400 icons. This also cleans up the object tree (yay!) so mappers can now view the /turf/ tree without a billion things bombarding them.

Changelog

Not needed, per SuperNovas comment.

…(Splitting up areas.dmi + code related stuff)
@github-actions github-actions bot added DME Edit (DEPRECEATED) THIS LABEL ISN'T USED ANYMORE. This PR contains an edit to tgstation.dme. Update jollystation.dme GitHub Code owners probably got touched for the 50th time this week and is now, still broken Map Edit You placed a single (one) poster in a hall. And its not even the right one. Congratulations. Tools What the fuck do these do Upstream Code (DEPRECATED) From /TG/Station - THIS LABEL IS NO LONGER USED. Upstream Sprites (DEPRECATED) From /TG/ Station, sprite edition - THIS LABEL IS NO LONGER USED. labels May 6, 2022
@Jolly-66
Copy link
Member

Jolly-66 commented May 6, 2022

Hahaha fuck

@Jolly-66 Jolly-66 self-assigned this May 6, 2022
@github-actions github-actions bot added the Merge Conflict Other PRs got merged that touch files in your PR that you edited. So, good luck label May 8, 2022
@Jolly-66 Jolly-66 removed the Merge Conflict Other PRs got merged that touch files in your PR that you edited. So, good luck label May 9, 2022
@Jolly-66 Jolly-66 merged commit 754bfea into master May 9, 2022
@Jolly-66 Jolly-66 deleted the upstream-merge-66726 branch May 9, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DME Edit (DEPRECEATED) THIS LABEL ISN'T USED ANYMORE. This PR contains an edit to tgstation.dme. Update jollystation.dme GitHub Code owners probably got touched for the 50th time this week and is now, still broken Map Edit You placed a single (one) poster in a hall. And its not even the right one. Congratulations. Tools What the fuck do these do Upstream Code (DEPRECATED) From /TG/Station - THIS LABEL IS NO LONGER USED. Upstream Sprites (DEPRECATED) From /TG/ Station, sprite edition - THIS LABEL IS NO LONGER USED.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants