fix(components): tooltips (#2413)

Talend · Sep 18, 2019 · 61654e6 · 61654e6
1 parent 563b069
commit 61654e6
Show file tree

Hide file tree

Showing 23 changed files with 2,517 additions and 2,710 deletions.
diff --git a/packages/components/src/ActionIntercom/__snapshots__/Intercom.component.test.js.snap b/packages/components/src/ActionIntercom/__snapshots__/Intercom.component.test.js.snap
@@ -21,39 +21,34 @@ exports[`Intercom button should render a button 1`] = `
     label="Chat with Talend Support"
     tooltipPlacement="bottom"
   >
-    <div
+    <button
       aria-describedby={42}
-      className="theme-tc-tooltip"
+      className="btn btn-link tc-intercom theme-tc-intercom"
+      id="my-intercom"
+      key=".0"
       onBlur={[Function]}
       onClick={[Function]}
       onFocus={[Function]}
       onKeyPress={[Function]}
       onMouseOut={[Function]}
       onMouseOver={[Function]}
     >
-      <button
-        aria-describedby={42}
-        className="btn btn-link tc-intercom theme-tc-intercom"
-        id="my-intercom"
-        key=".0"
+      <Icon
+        name="talend-bubbles"
       >
-        <Icon
+        <svg
+          aria-hidden="true"
+          className="theme-tc-svg-icon tc-svg-icon"
+          focusable="false"
           name="talend-bubbles"
+          title={null}
         >
-          <svg
-            aria-hidden="true"
-            className="theme-tc-svg-icon tc-svg-icon"
-            focusable="false"
-            name="talend-bubbles"
-            title={null}
-          >
-            <use
-              xlinkHref="#talend-bubbles"
-            />
-          </svg>
-        </Icon>
-      </button>
-    </div>
+          <use
+            xlinkHref="#talend-bubbles"
+          />
+        </svg>
+      </Icon>
+    </button>
   </TooltipTrigger>
 </Intercom>
 `;
diff --git a/.../components/src/Actions/ActionDropdown/__snapshots__/ActionDropdown.snapshot.test.js.snap b/.../components/src/Actions/ActionDropdown/__snapshots__/ActionDropdown.snapshot.test.js.snap
@@ -837,6 +837,12 @@ exports[`ActionDropdown should render icon only with hideLabel props 1`] = `
   i18n={Object {}}
   id="dropdown-id"
   key=".0"
+  onBlur={[Function]}
+  onClick={[Function]}
+  onFocus={[Function]}
+  onKeyPress={[Function]}
+  onMouseOut={[Function]}
+  onMouseOver={[Function]}
   onSelect={[Function]}
   onToggle={[Function]}
   role="button"
@@ -886,8 +892,13 @@ exports[`ActionDropdown should render icon only with hideLabel props 1`] = `
             i18n={Object {}}
             id="dropdown-id"
             key=".0"
+            onBlur={[Function]}
             onClick={[Function]}
+            onFocus={[Function]}
             onKeyDown={[Function]}
+            onKeyPress={[Function]}
+            onMouseOut={[Function]}
+            onMouseOver={[Function]}
             open={false}
             role="button"
             useAnchor={false}
@@ -905,8 +916,13 @@ exports[`ActionDropdown should render icon only with hideLabel props 1`] = `
               disabled={false}
               i18n={Object {}}
               id="dropdown-id"
+              onBlur={[Function]}
               onClick={[Function]}
+              onFocus={[Function]}
               onKeyDown={[Function]}
+              onKeyPress={[Function]}
+              onMouseOut={[Function]}
+              onMouseOver={[Function]}
               role="button"
             >
               <button
@@ -918,8 +934,13 @@ exports[`ActionDropdown should render icon only with hideLabel props 1`] = `
                 disabled={false}
                 i18n={Object {}}
                 id="dropdown-id"
+                onBlur={[Function]}
                 onClick={[Function]}
+                onFocus={[Function]}
                 onKeyDown={[Function]}
+                onKeyPress={[Function]}
+                onMouseOut={[Function]}
+                onMouseOver={[Function]}
                 role="button"
                 type="button"
               >

diff --git a/...c/Badge/BadgeComposition/BadgeCategory/__snapshots__/BadgeCategory.component.test.js.snap b/...c/Badge/BadgeComposition/BadgeCategory/__snapshots__/BadgeCategory.component.test.js.snap
@@ -1,14 +1,10 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`BadgeCategory should render with the label 1`] = `
-<div class="theme-tc-tooltip"
-     aria-describedby="42"
+<span aria-label="my badge label"
+      class="tc-badge-category theme-tc-badge-category"
+      aria-describedby="42"
 >
-  <span aria-label="my badge label"
-        class="tc-badge-category theme-tc-badge-category"
-        aria-describedby="42"
-  >
-    my badge label
-  </span>
-</div>
+  my badge label
+</span>
 `;
diff --git a/...s/src/Badge/BadgeComposition/BadgeDelete/__snapshots__/BadgeDelete.component.test.js.snap b/...s/src/Badge/BadgeComposition/BadgeDelete/__snapshots__/BadgeDelete.component.test.js.snap
@@ -1,24 +1,20 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`BadgeDelete should render 1`] = `
-<div class="theme-tc-tooltip"
-     aria-describedby="42"
+<button role="button"
+        aria-label="Delete"
+        id="tc-badge-delete-my-id"
+        aria-describedby="42"
+        type="button"
+        class="tc-badge-delete-icon theme-tc-badge-delete-icon btn-icon-only btn btn-link"
 >
-  <button role="button"
-          aria-label="Delete"
-          id="tc-badge-delete-my-id"
-          aria-describedby="42"
-          type="button"
-          class="tc-badge-delete-icon theme-tc-badge-delete-icon btn-icon-only btn btn-link"
+  <svg name="talend-cross"
+       class="theme-tc-svg-icon tc-svg-icon"
+       focusable="false"
+       aria-hidden="true"
   >
-    <svg name="talend-cross"
-         class="theme-tc-svg-icon tc-svg-icon"
-         focusable="false"
-         aria-hidden="true"
-    >
-      <use xlink:href="#talend-cross">
-      </use>
-    </svg>
-  </button>
-</div>
+    <use xlink:href="#talend-cross">
+    </use>
+  </svg>
+</button>
 `;
diff --git a/...nts/src/Badge/BadgeComposition/BadgeLabel/__snapshots__/BadgeLabel.component.test.js.snap b/...nts/src/Badge/BadgeComposition/BadgeLabel/__snapshots__/BadgeLabel.component.test.js.snap
@@ -2,14 +2,10 @@
 
 exports[`BadgeLabel should default render 1`] = `
 <div class="tc-badge-label theme-tc-badge-label">
-  <div class="theme-tc-tooltip"
-       aria-describedby="42"
+  <span class="tc-badge-label-text theme-tc-badge-label-text"
+        aria-describedby="42"
   >
-    <span class="tc-badge-label-text theme-tc-badge-label-text"
-          aria-describedby="42"
-    >
-      my label
-    </span>
-  </div>
+    my label
+  </span>
 </div>
 `;
diff --git a/packages/components/src/Badge/__snapshots__/Badge.component.test.js.snap b/packages/components/src/Badge/__snapshots__/Badge.component.test.js.snap
@@ -4,15 +4,11 @@ exports[`Badge should render by default 1`] = `
 <div class="tc-badge theme-tc-badge tc-badge-display-large theme-tc-badge-display-large tc-badge-readonly theme-tc-badge-readonly">
   <div class="tc-badge-button theme-tc-badge-button">
     <div class="tc-badge-label theme-tc-badge-label">
-      <div class="theme-tc-tooltip"
-           aria-describedby="42"
+      <span class="tc-badge-label-text theme-tc-badge-label-text"
+            aria-describedby="42"
       >
-        <span class="tc-badge-label-text theme-tc-badge-label-text"
-              aria-describedby="42"
-        >
-          my label
-        </span>
-      </div>
+        my label
+      </span>
     </div>
   </div>
 </div>