Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tracker.cs #32

Closed
wants to merge 1 commit into from
Closed

Conversation

eldri7ch
Copy link

Update the GetSeedData() void to actually get seed data from the preset json files.

Update the GetSeedData() void to actually get seed data from the preset json files.
@TalicZealot
Copy link
Owner

Can you describe the issue please. GetSeedData grabs the seed name and preset name from memory. Preset locks are then loaded by LoadLocks if the preset in memory is not custom and the preset file is in the presets folder following the same format.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths.presetFilePath does not exist. Paths.PresetPath points to the presets directory, which is then combined with the preset name extracted from memory to create path, which gets loaded.

@TalicZealot
Copy link
Owner

I did a debug trace just to be sure and it loads bat-master the way it is supposed to. Double check if your json file name matches what shows up in-game on the menu. A mismatch there would cause the tracker to look for a file that doesn't exist and default to custom settings.

@eldri7ch
Copy link
Author

When we first enter the castle as Alucard, the map should show Demon Card, Form of Mist, Leap Stone, and Merman Statue as layer 0.

Now, if I load a save file with progression relics, it does update correctly, except the level 0 checks, so I think it's an issue with new files and missing data in the .json (Missing checks are level 0)

open.zip
CAPTURE
CAPTURE2

@TalicZealot
Copy link
Owner

Can you sens over a ppf so that I can do a local test.

@TalicZealot
Copy link
Owner

Oh I think I see what's happening. You need to include the open locations with an empty lock array, otherwise the tracker won't know to overwrite the default locks. That's what I originally did here: https://github.com/TalicZealot/SotN-Randomizer/blob/7dfe92696e9a2caac964db6b36b9edbbde8b5e13/presets/open-casual.json#L101C1-L101C18

@eldri7ch
Copy link
Author

I updated the preset file and generated a new seed. It works perfectly now. Now I know to make new layer 0 checks with blank requirements. Thanks!

@eldri7ch
Copy link
Author

Issue resolved, no update needed.

@eldri7ch eldri7ch closed this Sep 30, 2023
@eldri7ch eldri7ch deleted the eldri7ch-patch-1 branch September 30, 2023 20:29
@TalicZealot
Copy link
Owner

Nice. For stuff like this an Issue works better. Since this is .net I wouldn't have been able to merge this. Unlike Javascript an undefined variable like this would not allow the program to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants