Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - update to Net::AMQP::RabbitMQ 0.31, where delivery_tag is UInt64 #7

Closed
wants to merge 1 commit into from
Closed

Fix - update to Net::AMQP::RabbitMQ 0.31, where delivery_tag is UInt64 #7

wants to merge 1 commit into from

Conversation

eilara
Copy link
Contributor

@eilara eilara commented Apr 17, 2015

From Net::AMQP::RabbitMQ Changes:

0.100000 - 2015-03-09
- Support for 64-bit delivery tags via Math::Int64 (manchicken)

But Crixa stores delivery tags as strings in the queue message, and as int (for easy inc/dec/reset) in the queue mock.

Changed:

  • Queue message delivery tag is UInt64 not string
  • Mock queue sends out delivery tags as UInt64 not int

@@ -11,7 +11,7 @@ our $VERSION = '0.12';
use Moose;

use Crixa::Channel;
use Net::AMQP::RabbitMQ 0.009000;
se Net::AMQP::RabbitMQ 0.310000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing the "u" in use.

@autarch autarch mentioned this pull request Apr 22, 2015
@autarch
Copy link
Member

autarch commented Apr 22, 2015

I made a new PR (#9) for this so I can add some additional tweaks.

@autarch autarch closed this Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants