Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THP encoding optimization #7

Closed
Tamk1s opened this issue Mar 9, 2020 · 1 comment
Closed

THP encoding optimization #7

Tamk1s opened this issue Mar 9, 2020 · 1 comment
Assignees
@Tamk1s
Labels
bug Something isn't working enhancement New feature or request

Comments

@Tamk1s
Copy link
Owner

Tamk1s commented Mar 9, 2020

When a THP video file requires dummy padding frame files for encoding, the FFMPEG conversion from BMP -> MP4 dummy videos is buggy, and usually creates videos sized larger than the Trunc_Frame limit. This in turn causes the final mp4 video file to be larger than the (trunc_frame * num_of_mults) limit, causing wasted time and temporary HDD space when ripping BMP/JPG frames for THP encoding. Thwimp lazily "fixes" problem by discarding extra frames.

Fix it by either fixing the BMP -> MP4 conversion to created the correct length video files, or just require the user to created pre-defined dummy video instead.
@Tamk1s Tamk1s added bug Something isn't working enhancement New feature or request labels Mar 9, 2020
@Tamk1s Tamk1s self-assigned this Mar 9, 2020
@Tamk1s Tamk1s mentioned this issue Mar 9, 2020
Closed
@Tamk1s
Copy link
Owner Author

Tamk1s commented Apr 7, 2020

The command line func for single BMP -> extended MP4 video had wrong order of params; fixed up and now working 👍

@Tamk1s Tamk1s closed this as completed Apr 7, 2020
Tamk1s added a commit that referenced this issue Apr 7, 2020
@Tamk1s
Bugfix #7 : THP Encoder optimization
cd7a663 
*Optimized THP Encoder, so that generation of dummy videos from a single dummy frame has the correct framecount (to optimize final MP4 video -> BMP -> JPG conversion near the final step)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tamk1s Tamk1s

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tamk1s