Add NixOS Flake #26

Svenum · 2024-04-20T21:58:00Z

I try to add the nixos flake, but I am not very experienced. So if you want to help, fell free. 😄

mdvmeijer · 2024-04-27T22:42:36Z

Hello, thank you for the PR. I also tried my hand at creating a Nix package for fw-fanctrl a while ago, but without the flake.

Using your package + flake, if I run nix build and run the resulting executable, I get the following repeated output:

Could not start dynamically linked executable: ectool
NixOS cannot run dynamically linked executables intended for generic
linux environments out of the box. For more information, see:
https://nix.dev/permalink/stub-ld

Are you able to successfully run fw-fanctrl using your flake? If so, how?

Svenum · 2024-04-28T09:25:38Z

Ok, I am able to build it just like you sad nix build and then there is the "result/bin" folder with the needed executables in it.

Svenum · 2024-04-28T09:26:15Z

I run my system on unstable branch of NixOS maybe that is something?

dantefromhell · 2024-04-28T12:49:13Z

I'm running into the same issue as @mdvmeijer reported, running on nixpkgs-unstable@2748d22b - although a slightly outdated (2 weeks old).

❯ cat /etc/os-release
ANSI_COLOR="1;34"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.05.20240413.90055d5"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.05 (Uakari)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.05 (Uakari)"
VERSION_CODENAME=uakari
VERSION_ID="24.05"
❯ nix build 'github:TamtamHero/fw-fanctrl/68a710cd3ac6ed0000cbb0bd147b6de4e0bd6689' && result/bin/ectool
Could not start dynamically linked executable: result/bin/ectool
NixOS cannot run dynamically linked executables intended for generic
linux environments out of the box. For more information, see:
https://nix.dev/permalink/stub-ld

Svenum · 2024-04-28T12:54:04Z

Ok, just to be sure you did this:

git clone https://github.com/Svenum/fw-fanctrl
cd fw-fanctrl
git checkout add-flake
nix build .

mdvmeijer · 2024-04-28T17:00:13Z

Yes, I followed those four steps. I'm wondering, are you using NixOS or just the Nix package manager on another distro? It seems like the package should just not work on NixOS since it uses the ./bin/ectool binary directly from this repo without any changes done for NixOS.

My guess for fixing this:

Add https://github.com/ssddq/fw-ectool as a flake input
Build the fw-ectool package as a dependency and add it to PATH (e.g. propagatedBuildInputs or makeWrapperArgs)

I would try this myself, but https://github.com/ssddq/fw-ectool doesn't seem to be updated to support AMD yet, so I'll first have to make a PR for that. I don't have easy access to my Intel FW for now.

Svenum · 2024-04-28T17:14:56Z

Ok, weird. I use NixOS. I dont understand why I could build this and you dont. Yes to add it as build input could work.
I'll try. I have an framework 16 I hope it works if you say it does not work on amd.

mdvmeijer · 2024-04-28T17:25:10Z

Hmm okay, then I'm not sure. Could be that you have ectool already installed globally? But if not then I'm also out of ideas.

Svenum · 2024-04-28T17:26:53Z

Not that I know.... But does not matter. I add it to the build inputs that it work for everyone 😉

Svenum · 2024-05-03T19:18:39Z

Sorry for the late respond @mdvmeijer @dantefromhell. I added the built input now.

Svenum · 2024-05-03T21:31:20Z

@mdvmeijer @dantefromhell @TamtamHero:

I have got it working, but now I got this errors:

Missing Chromium EC memory map.
Cannot find I2C adapter
Unable to establish host communication
Couldn't find EC
Missing Chromium EC memory map.
Cannot find I2C adapter
Unable to establish host communication
Couldn't find EC
model: Framework laptop 13, cpu_type: AMD, fan_count: 0
Missing Chromium EC memory map.
Cannot find I2C adapter
Unable to establish host communication
Couldn't find EC
speed: 15% temp: 0°C movingAverage: 0.0°C
Missing Chromium EC memory map.
Cannot find I2C adapter
Unable to establish host communication
Couldn't find EC

And I have an Framework 16 but it says: model: Framework laptop 13, cpu_type: AMD, fan_count: 0

leopoldhub · 2024-06-01T15:06:09Z

Just synced the nix branch

Svenum · 2024-06-01T16:34:31Z

@leopoldhub please check my answers and the new code. 😄

install.sh

pre-uninstall.sh

install.sh

leopoldhub · 2024-06-01T17:20:21Z

I will check everything one more time, but it should be good 👍

leopoldhub

should be the last small one

.github/workflows/nix-build.yml

leopoldhub · 2024-06-01T17:30:59Z

Congratulations 🎉
All is well on my end, thanks again for all your hard work and contribution to this project!
@Svenum , would you like to be assigned automatically when a nix-related issue is opened?

Svenum · 2024-06-01T17:32:07Z

Yes, I would love too help in the future on the nix side of this project. So assigning me is fine 👍

* initial * update gitignore * update inputs * add fw-ectool dependencie * add module * fix tabs * fix package * fix typo * fix service * fix type * add options * fix service * fix build inputs * add Readme + add suspend script * remove unneeded }; * fix pkgs.writeShellScript * remvoe \ * try * add self * fix module * update package * fix package * use sleep script * add config options * fix typo * fix typo * add defaults * fix type * add prettyier * remove beautifyer * udpate readme * update installer script * add missing path * Update README.md Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Update flake.nix Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Update nix/module.nix Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * add descriptions * fix uninstall * update readme * add description * remove requiremetns.txt + add github actions * update action * rename workflow test * fix service * try * try * Update README.md * Update README.md * chagne flake description * fix suspend script * fix script * fix path * fix install.sh * fix --no-sudo * add --no-sudo to other scripts * fix check * add option check * add missing " * Rename nix action --------- Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

@Svenum

* Adding @Svenum as an assignee to nix-related issues (#43) * Fixing adding @Svenum as an assignee to nix-related issues (#44) (non contributors cannot be assigned to issues) * Reload will report if config couldn't be parsed and the service keeps running. (#46) Authored-by: Nina Alexandra Klama <nina-git@klama.name> * Removing binary blobs from the project (#51) * removing binary blobs from the project. we now fetch the ectool from the gitlab artifacts and confirm the checksum. * remove bin references from README.md * extracting $TEMP_FOLDER from installEctool * Fix README spelling/grammer, fix "FrameWork" capitalization in service description (#52) * Review README spelling/grammar * Fix "FrameWork" capitalization in service * Clarify behaviour on service stop or pause (#53) (#55) * Separating FanController into different subclasses to allow HardwareController and SocketController diversity. 2 (Repost of #50) (#58) * separating `FanController` into different subclasses to allow `HardwareController` and `SocketController` diversity * adding the new arguments into the README.md * fixing an indentation error causing `--strategy <strategy>` not to work (the simple `<strategy>` still worked) * fixing missing print for command execution (#63) * forcing utf-8 encoding for socket messages and usage of stopServerSocket method instead of manual closing, as well as updating error detection pattern (#64) * README.md documentation update (#65) * forcing utf-8 encoding for socket messages and usage of stopServerSocket method instead of manual closing, as well as updating error detection pattern * README.md documentation update * change log format on fatal crash * fix badges links * adding windows platform badge and issue template * fix `:` instead of `=` * disabling part of the README.md while waiting for merge * Command arguments refactoring Pt.1 (#66) * forcing utf-8 encoding for socket messages and usage of stopServerSocket method instead of manual closing, as well as updating error detection pattern * README.md documentation update * change log format on fatal crash * fix badges links * adding windows platform badge and issue template * fix `:` instead of `=` * first part of the command argument refactoring. the old argument format is deprecated but still usable. improved feedback when executing commands. #31 * trim blank lines in README.md * finishing touches (#67) * add no battery mode for mainboards without battery (#69) * add configuration for no battery mode in hardware controller * fix wrong line getting noBatteryMode * dynamically fetching battery sensor on init/reload * add --no-battery flag for install * update readme with --no-battery flag * rework no battery config to come from service args * change sensors to be ectool specific - reword the argument to be more clear about battery sensors - move `noBatteryMode` and `nonBatterySensors` to EctoolHardwareController - update `getNonBatterySensors` to be able to handle more than one sensor - update installer and readme accordingly * update grep command for checking existing `--no-battery-sensors` * combine getTemperature functions to one * add documentation for run option `--no-battery-sensors` * rename variable `NO_BATTERY` to `NO_BATTERY_SENSOR` * update the installer to use existing placeholder format * rename noBatterySensorMode variables and functions for clarity * rename placeholder to `NO_BATTERY_SENSOR_OPTION` for clarity * update comments in installer to reflect new argument name * adding ectool sub-dependency to documentation (#70) * typo "tempurature" => "temperature" (#71) typo "tempurature" => "temperature" * typo "tempurature" => "temperature" (#72) typo "tempurature" => "temperature" * Add ToC + link to NixOS Documentation (#75) * add doc folder * update nix link * add toc * add link * add missin # * add doc * fix link * add new line under titles * add --no-sudo option (#76) * Add choice to print fan speed percentage (#78) * Add option to print current speed percentage * Update README.md * Update commands.md * Add print choice descriptions to help text * add missing no_sudo check (#79) * Add NixOS Flake (#26) * initial * update gitignore * update inputs * add fw-ectool dependencie * add module * fix tabs * fix package * fix typo * fix service * fix type * add options * fix service * fix build inputs * add Readme + add suspend script * remove unneeded }; * fix pkgs.writeShellScript * remvoe \ * try * add self * fix module * update package * fix package * use sleep script * add config options * fix typo * fix typo * add defaults * fix type * add prettyier * remove beautifyer * udpate readme * update installer script * add missing path * Update README.md Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Update flake.nix Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Update nix/module.nix Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * add descriptions * fix uninstall * update readme * add description * remove requiremetns.txt + add github actions * update action * rename workflow test * fix service * try * try * Update README.md * Update README.md * chagne flake description * fix suspend script * fix script * fix path * fix install.sh * fix --no-sudo * add --no-sudo to other scripts * fix check * add option check * add missing " * Rename nix action --------- Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Update branch to main branch (#54) * Adding @Svenum as an assignee to nix-related issues (#43) * Fixing adding @Svenum as an assignee to nix-related issues (#44) (non contributors cannot be assigned to issues) * Reload will report if config couldn't be parsed and the service keeps running. (#46) Authored-by: Nina Alexandra Klama <nina-git@klama.name> * Removing binary blobs from the project (#51) * removing binary blobs from the project. we now fetch the ectool from the gitlab artifacts and confirm the checksum. * remove bin references from README.md * extracting $TEMP_FOLDER from installEctool * Fix README spelling/grammer, fix "FrameWork" capitalization in service description (#52) * Review README spelling/grammar * Fix "FrameWork" capitalization in service * use ectool form nixpkgs * update flake * remove old deps * remove duplicated pkgs --------- Co-authored-by: Léopold Hubert <hubertleopold01@gmail.com> Co-authored-by: Nina Alexandra Klama <github@fklama.de> Co-authored-by: DeflateAwning <11021263+DeflateAwning@users.noreply.github.com> * Update to main branch + switch to fw-ectool (#61) * Adding @Svenum as an assignee to nix-related issues (#43) * Fixing adding @Svenum as an assignee to nix-related issues (#44) (non contributors cannot be assigned to issues) * Reload will report if config couldn't be parsed and the service keeps running. (#46) Authored-by: Nina Alexandra Klama <nina-git@klama.name> * Removing binary blobs from the project (#51) * removing binary blobs from the project. we now fetch the ectool from the gitlab artifacts and confirm the checksum. * remove bin references from README.md * extracting $TEMP_FOLDER from installEctool * Fix README spelling/grammer, fix "FrameWork" capitalization in service description (#52) * Review README spelling/grammar * Fix "FrameWork" capitalization in service * Clarify behaviour on service stop or pause (#53) (#55) * Separating FanController into different subclasses to allow HardwareController and SocketController diversity. 2 (Repost of #50) (#58) * separating `FanController` into different subclasses to allow `HardwareController` and `SocketController` diversity * adding the new arguments into the README.md * fixing an indentation error causing `--strategy <strategy>` not to work (the simple `<strategy>` still worked) * add fw-ectool in module * fixing missing print for command execution (#63) --------- Co-authored-by: Léopold Hubert <hubertleopold01@gmail.com> Co-authored-by: Nina Alexandra Klama <github@fklama.de> Co-authored-by: DeflateAwning <11021263+DeflateAwning@users.noreply.github.com> * add doc + .gitignore * Add NixOS Flake (#26) * initial * update gitignore * update inputs * add fw-ectool dependencie * add module * fix tabs * fix package * fix typo * fix service * fix type * add options * fix service * fix build inputs * add Readme + add suspend script * remove unneeded }; * fix pkgs.writeShellScript * remvoe \ * try * add self * fix module * update package * fix package * use sleep script * add config options * fix typo * fix typo * add defaults * fix type * add prettyier * remove beautifyer * udpate readme * update installer script * add missing path * Update README.md Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Update flake.nix Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Update nix/module.nix Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * add descriptions * fix uninstall * update readme * add description * remove requiremetns.txt + add github actions * update action * rename workflow test * fix service * try * try * Update README.md * Update README.md * chagne flake description * fix suspend script * fix script * fix path * fix install.sh * fix --no-sudo * add --no-sudo to other scripts * fix check * add option check * add missing " * Rename nix action --------- Co-authored-by: Thomas Eizinger <thomas@eizinger.io> * Update branch to main branch (#54) * Adding @Svenum as an assignee to nix-related issues (#43) * Fixing adding @Svenum as an assignee to nix-related issues (#44) (non contributors cannot be assigned to issues) * Reload will report if config couldn't be parsed and the service keeps running. (#46) Authored-by: Nina Alexandra Klama <nina-git@klama.name> * Removing binary blobs from the project (#51) * removing binary blobs from the project. we now fetch the ectool from the gitlab artifacts and confirm the checksum. * remove bin references from README.md * extracting $TEMP_FOLDER from installEctool * Fix README spelling/grammer, fix "FrameWork" capitalization in service description (#52) * Review README spelling/grammar * Fix "FrameWork" capitalization in service * use ectool form nixpkgs * update flake * remove old deps * remove duplicated pkgs --------- Co-authored-by: Léopold Hubert <hubertleopold01@gmail.com> Co-authored-by: Nina Alexandra Klama <github@fklama.de> Co-authored-by: DeflateAwning <11021263+DeflateAwning@users.noreply.github.com> * Update to main branch + switch to fw-ectool (#61) * Adding @Svenum as an assignee to nix-related issues (#43) * Fixing adding @Svenum as an assignee to nix-related issues (#44) (non contributors cannot be assigned to issues) * Reload will report if config couldn't be parsed and the service keeps running. (#46) Authored-by: Nina Alexandra Klama <nina-git@klama.name> * Removing binary blobs from the project (#51) * removing binary blobs from the project. we now fetch the ectool from the gitlab artifacts and confirm the checksum. * remove bin references from README.md * extracting $TEMP_FOLDER from installEctool * Fix README spelling/grammer, fix "FrameWork" capitalization in service description (#52) * Review README spelling/grammar * Fix "FrameWork" capitalization in service * Clarify behaviour on service stop or pause (#53) (#55) * Separating FanController into different subclasses to allow HardwareController and SocketController diversity. 2 (Repost of #50) (#58) * separating `FanController` into different subclasses to allow `HardwareController` and `SocketController` diversity * adding the new arguments into the README.md * fixing an indentation error causing `--strategy <strategy>` not to work (the simple `<strategy>` still worked) * add fw-ectool in module * fixing missing print for command execution (#63) --------- Co-authored-by: Léopold Hubert <hubertleopold01@gmail.com> Co-authored-by: Nina Alexandra Klama <github@fklama.de> Co-authored-by: DeflateAwning <11021263+DeflateAwning@users.noreply.github.com> --------- Co-authored-by: Léopold Hubert <hubertleopold01@gmail.com> Co-authored-by: Nina Alexandra Klama <github@fklama.de> Co-authored-by: DeflateAwning <11021263+DeflateAwning@users.noreply.github.com> Co-authored-by: Oli Thornton <50975890+saizo80@users.noreply.github.com> Co-authored-by: Ryan <speenah@pm.me> Co-authored-by: Thomas Eizinger <thomas@eizinger.io>

Svenum added 3 commits April 20, 2024 23:56

initial

91883a2

update gitignore

2429c60

update inputs

68a710c

Svenum added 2 commits May 3, 2024 21:17

add fw-ectool dependencie

231f2ca

Merge branch 'main' into add-flake

a0a5e2a

Svenum added 9 commits May 3, 2024 22:35

add module

f06e0f5

fix tabs

aac9461

fix package

eaa983c

fix typo

1ef9e72

fix service

8016fec

fix type

f50d730

add options

f27ee51

fix service

bd33e85

fix build inputs

ab6de2c

Svenum mentioned this pull request May 3, 2024

Nix package #19

Closed

Svenum added 4 commits May 3, 2024 23:48

add Readme + add suspend script

398203c

remove unneeded };

4e823a9

fix pkgs.writeShellScript

690795e

remvoe \

bf785d2

Svenum added 4 commits June 1, 2024 16:48

Update README.md

c74fcd5

chagne flake description

9ea8fb6

fix suspend script

3163d8e

fix script

f8ad4b8

Svenum and others added 5 commits June 1, 2024 18:16

fix path

023b74f

Merge branch 'packaging/nix' into add-flake

d171862

fix install.sh

6f3a1f0

Merge branch 'add-flake' of github.com:Svenum/fw-fanctrl into add-flake

161a7a9

fix --no-sudo

36b4492

leopoldhub reviewed Jun 1, 2024

View reviewed changes

install.sh Outdated Show resolved Hide resolved

add --no-sudo to other scripts

23dc250

leopoldhub requested changes Jun 1, 2024

View reviewed changes

install.sh Outdated Show resolved Hide resolved

install.sh Outdated Show resolved Hide resolved

pre-uninstall.sh Outdated Show resolved Hide resolved

Svenum added 2 commits June 1, 2024 19:11

fix check

3e20444

add option check

053eec9

leopoldhub reviewed Jun 1, 2024

View reviewed changes

install.sh Outdated Show resolved Hide resolved

add missing "

f68de1e

leopoldhub requested changes Jun 1, 2024

View reviewed changes

.github/workflows/nix-build.yml Outdated Show resolved Hide resolved

Rename nix action

61aebd4

leopoldhub approved these changes Jun 1, 2024

View reviewed changes

leopoldhub merged commit f7afb49 into TamtamHero:packaging/nix Jun 1, 2024

Svenum deleted the add-flake branch June 28, 2024 11:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add NixOS Flake #26

Add NixOS Flake #26

Svenum commented Apr 20, 2024

mdvmeijer commented Apr 27, 2024

Svenum commented Apr 28, 2024

Svenum commented Apr 28, 2024

dantefromhell commented Apr 28, 2024

Svenum commented Apr 28, 2024

mdvmeijer commented Apr 28, 2024

Svenum commented Apr 28, 2024

mdvmeijer commented Apr 28, 2024

Svenum commented Apr 28, 2024

Svenum commented May 3, 2024

Svenum commented May 3, 2024

leopoldhub commented Jun 1, 2024

Svenum commented Jun 1, 2024

leopoldhub commented Jun 1, 2024

leopoldhub left a comment •

edited

Loading

leopoldhub commented Jun 1, 2024

Svenum commented Jun 1, 2024

Add NixOS Flake #26

Add NixOS Flake #26

Conversation

Svenum commented Apr 20, 2024

mdvmeijer commented Apr 27, 2024

Svenum commented Apr 28, 2024

Svenum commented Apr 28, 2024

dantefromhell commented Apr 28, 2024

Svenum commented Apr 28, 2024

mdvmeijer commented Apr 28, 2024

Svenum commented Apr 28, 2024

mdvmeijer commented Apr 28, 2024

Svenum commented Apr 28, 2024

Svenum commented May 3, 2024

Svenum commented May 3, 2024

leopoldhub commented Jun 1, 2024

Svenum commented Jun 1, 2024

leopoldhub commented Jun 1, 2024

leopoldhub left a comment • edited Loading

Choose a reason for hiding this comment

leopoldhub commented Jun 1, 2024

Svenum commented Jun 1, 2024

leopoldhub left a comment •

edited

Loading