-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(FieldAPI): Change from touched error message and error message to error map and array of errors #442
Conversation
8fc65e7
to
9ae2c18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic start! There's some super minor nitpicks here, but you're on an amazing track!
…e to error map and array of errors BREAKING CHANGE: The touched Error and error field has been removed will be replaced with touched errors array and errors map.
9ae2c18
to
696a93d
Compare
57e5ee5
to
5111921
Compare
# Conflicts: # examples/react/simple/package.json # examples/vue/simple/package.json # pnpm-lock.yaml
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportPatch coverage is ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
We'd like to change our validators to return an object and array of errors to avoid UX limitations for any app that uses TanStack Form.
Quoted from @crutchcorn. Based on the changes, an example usage in our react adapter would be:
This change includes:
FieldMeta.error
withFieldMeta.errors
andFieldMeta.errorMap
FieldMeta.touchedError
withFieldMeta.touchedErrors
Resolves #431