fix(core): re-validate the subfields after one of them have been removed #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit df0b7d6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
fulopkovacs
force-pushed
the
fix-array-validation-when-a-field-is-removed
branch
from
0815891
to
df0b7d6
Compare
crutchcorn
reviewed
May 28, 2024
Comment on lines
+189
to
+191
| ;[form, field, subField1, subField2, subField3, subField4].forEach((f) => | ||
| f.mount(), | ||
| ) |
There was a problem hiding this comment.
Not blocking, but in the future let's avoid using forEach. It's more things to type out, but I really dislike programmatic logic in our tests as it makes things harder to debug.
crutchcorn
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #629