Skip to content

Commit c2ece73

Browse files
sukvvonmanudeli
andauthored
test(svelte-query/createMutation): remove 'vi.waitFor', and add 'advanceTimersByTimeAsync' (#9414)
Co-authored-by: Jonghyeon Ko <manudeli.ko@gmail.com>
1 parent 0cd4e7d commit c2ece73

File tree

1 file changed

+27
-58
lines changed

1 file changed

+27
-58
lines changed

packages/svelte-query/tests/createMutation/createMutation.test.ts

Lines changed: 27 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,17 @@ describe('createMutation', () => {
1717
test('Able to reset `error`', async () => {
1818
const rendered = render(ResetExample)
1919

20-
await vi.waitFor(() => {
21-
expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()
22-
})
20+
expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()
2321

2422
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
25-
26-
await vi.waitFor(() => {
27-
expect(
28-
rendered.queryByText('Error: Expected mock error'),
29-
).toBeInTheDocument()
30-
})
23+
await vi.advanceTimersByTimeAsync(0)
24+
expect(
25+
rendered.queryByText('Error: Expected mock error'),
26+
).toBeInTheDocument()
3127

3228
fireEvent.click(rendered.getByRole('button', { name: /Reset/i }))
33-
34-
await vi.waitFor(() => {
35-
expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()
36-
})
29+
await vi.advanceTimersByTimeAsync(0)
30+
expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()
3731
})
3832

3933
test('Able to call `onSuccess` and `onSettled` after each successful mutate', async () => {
@@ -47,29 +41,21 @@ describe('createMutation', () => {
4741
},
4842
})
4943

50-
await vi.waitFor(() => {
51-
expect(rendered.queryByText('Count: 0')).toBeInTheDocument()
52-
})
44+
expect(rendered.queryByText('Count: 0')).toBeInTheDocument()
5345

5446
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
5547
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
5648
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
49+
await vi.advanceTimersByTimeAsync(0)
50+
expect(rendered.queryByText('Count: 3')).toBeInTheDocument()
5751

58-
await vi.waitFor(() => {
59-
expect(rendered.queryByText('Count: 3')).toBeInTheDocument()
60-
})
61-
62-
await vi.waitFor(() => {
63-
expect(onSuccessMock).toHaveBeenCalledTimes(3)
64-
})
52+
expect(onSuccessMock).toHaveBeenCalledTimes(3)
6553

6654
expect(onSuccessMock).toHaveBeenCalledWith(1)
6755
expect(onSuccessMock).toHaveBeenCalledWith(2)
6856
expect(onSuccessMock).toHaveBeenCalledWith(3)
6957

70-
await vi.waitFor(() => {
71-
expect(onSettledMock).toHaveBeenCalledTimes(3)
72-
})
58+
expect(onSettledMock).toHaveBeenCalledTimes(3)
7359

7460
expect(onSettledMock).toHaveBeenCalledWith(1)
7561
expect(onSettledMock).toHaveBeenCalledWith(2)
@@ -96,41 +82,24 @@ describe('createMutation', () => {
9682
},
9783
})
9884

99-
await vi.waitFor(() =>
100-
expect(rendered.queryByText('Data: undefined')).toBeInTheDocument(),
101-
)
85+
expect(rendered.queryByText('Data: undefined')).toBeInTheDocument()
10286

10387
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
104-
await vi.waitFor(() =>
105-
expect(rendered.getByText('Data: undefined')).toBeInTheDocument(),
106-
)
107-
await vi.waitFor(() =>
108-
expect(rendered.getByText('Status: error')).toBeInTheDocument(),
109-
)
110-
await vi.waitFor(() =>
111-
expect(rendered.getByText('Failure Count: 1')).toBeInTheDocument(),
112-
)
113-
await vi.waitFor(() =>
114-
expect(
115-
rendered.getByText('Failure Reason: Expected mock error'),
116-
).toBeInTheDocument(),
117-
)
88+
expect(rendered.getByText('Data: undefined')).toBeInTheDocument()
89+
await vi.advanceTimersByTimeAsync(0)
90+
expect(rendered.getByText('Status: error')).toBeInTheDocument()
91+
expect(rendered.getByText('Failure Count: 1')).toBeInTheDocument()
92+
expect(
93+
rendered.getByText('Failure Reason: Expected mock error'),
94+
).toBeInTheDocument()
11895

11996
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
120-
await vi.waitFor(() =>
121-
expect(rendered.getByText('Status: pending')).toBeInTheDocument(),
122-
)
123-
await vi.waitFor(() =>
124-
expect(rendered.getByText('Status: success')).toBeInTheDocument(),
125-
)
126-
await vi.waitFor(() =>
127-
expect(rendered.getByText('Data: 2')).toBeInTheDocument(),
128-
)
129-
await vi.waitFor(() =>
130-
expect(rendered.getByText('Failure Count: 0')).toBeInTheDocument(),
131-
)
132-
await vi.waitFor(() =>
133-
expect(rendered.getByText('Failure Reason: null')).toBeInTheDocument(),
134-
)
97+
await vi.advanceTimersByTimeAsync(0)
98+
expect(rendered.getByText('Status: pending')).toBeInTheDocument()
99+
await vi.advanceTimersByTimeAsync(6)
100+
expect(rendered.getByText('Status: success')).toBeInTheDocument()
101+
expect(rendered.getByText('Data: 2')).toBeInTheDocument()
102+
expect(rendered.getByText('Failure Count: 0')).toBeInTheDocument()
103+
expect(rendered.getByText('Failure Reason: null')).toBeInTheDocument()
135104
})
136105
})

0 commit comments

Comments
 (0)