Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance error undefined message #5253

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

DylanJu
Copy link
Contributor

@DylanJu DylanJu commented Apr 11, 2023

In production, it's hard to debug if got undefined data because error message don't tell which query is the problem.
To find the query or api, a developer should look many network logs. It's hard things and makes spend a lot of time.

when undefined error occurs production only, there is no clue which one is broken.

If throw "undefined" error with which query is the problem it makes easy to debug and save a lot of time.
Actually, this is from my experience. https://discord.com/channels/719702312431386674/1094894443447980152/1094894443447980152

@vercel
Copy link

vercel bot commented Apr 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Apr 24, 2023 2:55pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 11, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5d26428:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@DylanJu DylanJu force-pushed the refactor/enhance-error-message branch from 66b2ae7 to 98efbf3 Compare April 11, 2023 15:05
@DylanJu DylanJu force-pushed the refactor/enhance-error-message branch from 98efbf3 to 8389312 Compare April 12, 2023 01:12
@DylanJu DylanJu changed the title refactor: enhance error undfined message refactor: enhance error undefined message Apr 12, 2023
@nx-cloud
Copy link

nx-cloud bot commented Apr 24, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5d26428. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 24, 2023

you need to adapt the test that checks for this message please

@DylanJu
Copy link
Contributor Author

DylanJu commented Apr 24, 2023

fixed 5d26428

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.48 ⚠️

Comparison is base (7cd2d19) 92.26% compared to head (5d26428) 91.78%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5253      +/-   ##
==========================================
- Coverage   92.26%   91.78%   -0.48%     
==========================================
  Files         112      101      -11     
  Lines        4267     3884     -383     
  Branches     1111      971     -140     
==========================================
- Hits         3937     3565     -372     
+ Misses        309      298      -11     
  Partials       21       21              
Impacted Files Coverage Δ
packages/query-core/src/query.ts 99.03% <100.00%> (ø)

... and 11 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo TkDodo merged commit dc2af81 into TanStack:main Apr 24, 2023
@DylanJu DylanJu deleted the refactor/enhance-error-message branch September 27, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants