Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query-core): add deprecated hint for isDataEqual #5962

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

Mini-ghost
Copy link
Contributor

The isDataEqual function in QueryObserver has been deprecated, and it is recommended to use structuralSharing instead. Currently, it will only be displayed through the console during development execution. Adding this TSDoc annotation can enable ESLint to help us check whether it is being used. These are deprecated APIs.

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2023 3:09pm

@nx-cloud
Copy link

nx-cloud bot commented Sep 5, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0616e0b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0616e0b:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Files Changed Coverage
packages/vue-query/src/useBaseQuery.ts ø
packages/vue-query/src/useInfiniteQuery.ts ø
packages/vue-query/src/useQuery.ts ø

📢 Thoughts on this report? Let us know!.

@TkDodo TkDodo merged commit 716c5d8 into TanStack:main Sep 5, 2023
7 checks passed
@Mini-ghost Mini-ghost deleted the chore/add-deprecated-tsdoc branch September 6, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants