Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reat-query): infer data type correctly when conditional skipToken is passed to useQueries #7037

Closed
wants to merge 2 commits into from

Conversation

Jaaneek
Copy link
Contributor

@Jaaneek Jaaneek commented Mar 6, 2024

closes #7035

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Mar 9, 2024 2:41pm

Copy link

nx-cloud bot commented Mar 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 19dce13. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3
nx run-many --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3

Sent with 💌 from NxCloud.

@TkDodo
Copy link
Collaborator

TkDodo commented Mar 9, 2024

hm, this creates some more type errors when applying defaultedQueries. I don't really see why, but I get the same results when trying to apply the fix to solid/vue/svelte ...

@TkDodo
Copy link
Collaborator

TkDodo commented Mar 22, 2024

superseded by:

@TkDodo TkDodo closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useQueries + skipToken looses .data type inference
2 participants