Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solid-js adapter #25

Merged
merged 9 commits into from
Oct 9, 2023
Merged

Conversation

wobsoriano
Copy link
Contributor

@wobsoriano wobsoriano commented Sep 11, 2023

This PR:

  • Adds initial implementation of the Solid adapter
  • Adds initial tests for the Solid adapter

Note: I am having some issues trying to replicate tests from the React and Vue adapters. For some reason, it's not rendering the component you pass in the render function from @solidjs/testing-library. As an alternative, the same module offers a renderHook function which lets us easily test a hook / primitive.

Closes #5

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Apologies for the delay on my end. Merging and publishing now

@crutchcorn crutchcorn merged commit cfda5c5 into TanStack:main Oct 9, 2023
1 check passed
@wobsoriano
Copy link
Contributor Author

Thank you for checking this out. I appreciate it @crutchcorn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solid Adapter
3 participants