Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular examples and dependencies improvements #5546

Merged
merged 3 commits into from
May 12, 2024
Merged

Angular examples and dependencies improvements #5546

merged 3 commits into from
May 12, 2024

Conversation

arnoud-dv
Copy link
Contributor

@arnoud-dv arnoud-dv commented May 12, 2024 •
edited
Loading

  • tslib should be a dependency, see https://angular.io/guide/angular-package-format#tslib
  • ng-packagr as dev dependency of angular package as in Query. We try to keep dependencies local where applicable
  • copied .devcontainer.json files from TanStack Query to Angular examples so that they are run as webcontainer on Code Sandbox. Angular CLI works more reliable in dev / web containers.

@arnoud-dv arnoud-dv marked this pull request as draft May 12, 2024 10:25
@arnoud-dv arnoud-dv changed the title tslib should be a dependency, see: Angular adapter improvements May 12, 2024
@arnoud-dv arnoud-dv changed the title Angular adapter improvements Angular examples and dependencies improvements May 12, 2024
@arnoud-dv arnoud-dv marked this pull request as ready for review May 12, 2024 12:25
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 12, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 57c2726. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@KevinVandy KevinVandy merged commit 2c916d2 into TanStack:feat-angular-table May 12, 2024
2 checks passed
KevinVandy added a commit that referenced this pull request May 12, 2024
@KevinVandy @jrgokavalsa
@riccardoperra @merto20 @arnoud-dv
feat: Angular adapter for TanStack Table (#5326) (#5432)
91f4360 
* feat(angular-table): adds Angular adapter for tanstack/table (#5326)

* Angular adapter for tanstack table initial

* build with: ng packagr

* Add angular examples basic grouping

* Add angular examples basic grouping

* Update angular examples basic grouping

* Add angular example selection

* regen lock file

* package upgrades, angular table docs

* prettier

* move around some deps

* removed unused dependency from angular package

* fix deps

---------

Co-authored-by: Kevin Van Cott <kevinvandy656@gmail.com>

* docs config cleanup

* feat: signal angular table adapter implementation

* update demo

* feat: table proxy detect memoized fns

* fix proxy property returning value

* feat: improve naming

* save new reference of table signal on every update

* computed trap proxy for fns with 1 argument

* update pnpm-lock.yaml

* refactor proxy implementation

* fix dependencies

* cleanup imports

* refactor basic example

* fix build

* run prettier

* add grouping example, fix ci

* add grouping example, fix ci

* add row selection example

* add column visibility example

* update examples add signal input required example

* improve angular table impl, fix flex-render change detection issues

* fix build

* feat(angular-table): improve adapter implementation (#5524)

* feat(angular-table): support render dynamic components and templateRefs in table

* update row selection example using dynamic rendered components

* support change detection on push with flex render

* add column ordering example

* fix flexRender change detection issues

* rename properties

* fix prettier and adjust example budget options

* update basic example

* add again support for table signal

* add column-pinning example

* add column pinning example

* add filters example

* cleanup code

* example cleanup

* update lock file

* feat(angular-table): added injector optional parameter for more flexibility (#5525)

* feat(angular-table): improve adapter implementation (#5524)

* Added optional injector for more flexibility
* Replace runInInjectionContext with injector in effect

* feat(angular-table): Added proxifyTable back

* feat(angular-table): adding back notifier signal for table changed

* feat(angular-table): Improve logic in setting table options
*set table options inside computed before returning the table instance
*remove redundant signals and effect
*remove injector as it no longer required
*update Grouping example to show how to pass signal when creating table

* update angular adapter and state docs

* prettier

* update docs config with angular examples

* update angular table state docs (#5545)

* Angular examples and dependencies improvements (#5546)

* tslib should be a dependency, see:

https://angular.io/guide/angular-package-format#tslib

* ensure angular examples are run as web container on code sandbox

* update lock file

---------

Co-authored-by: Kevin Vandy <kevinvandy656@gmail.com>

* docs(angular-table): Add documentation for FlexRenderDirective (#5543)

* add flexRender documentation

* fix docs

* fix rendering component section heading

* remove double build package.json from angular build

* update link name

* docs pass

* update esm exports in package.json

* update flexrender types

---------

Co-authored-by: jrgokavalsa <86955546+jrgokavalsa@users.noreply.github.com>
Co-authored-by: riccardoperra <riccardo.perra@icloud.com>
Co-authored-by: Riccardo Perra <perrariccardo0@gmail.com>
Co-authored-by: mamerto-g <merto.20@gmail.com>
Co-authored-by: Arnoud <6420061+arnoud-dv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinVandy KevinVandy KevinVandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnoud-dv @KevinVandy