feat(router): opt-out of codesanbox examples #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SeanCassiere is attempting to deploy a commit to the Tanstack Team on Vercel. A member of the Team first needs to authorize it. |
SeanCassiere
changed the title
|
failing build, but also, is completely hiding CSB a good idea? I've dealt with the issues above, but it can still be a good alternative for some. |
Build was a prettier thing on the vite config. With regards to CSB, it's been more of a hindrance to us on Router. More often than not, it's a process of us having to export the repro into GH, and import it into Stackblitz to actually work on the repro. |
KevinVandy
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opting-out of providing codesanbox urls for Router.
CSB repros are practically impossible to make changes to and test alternatives AND they make you need to pray to a deity to actually get the packages to upgrade to latest.