Changes to public holidays for Singapore and Ireland #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Lunar New year to Chinese New Year and corrected the logic of St Brigids day in Ireland
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tandadocs.atlassian.net/browse/L2S-3600?focusedCommentId=85958 - L2S-3600
Singapore accounts wanted Lunar new year to be renamed to Chinese New year
Ireland reported that St Brigid's day for next year is incorrect, St Brigids day public holiday lands on the first Monday in February unless the !st of Feb is Friday, in which case it will be Friday. Made changes to handle this.