feat(group-uploads-view): Add Verification to group uploads #3704
Conversation
…group upload Add three buttons - Verify - Edit - Delete These buttons float when scrolling on a page Refs #3703
- Lock form responses when in uploads view - Allow users to delete response when viewing upload - Add groups edit component - Refs #3703
Hide Action bar from the dynamic table when viewing form responses from the group uploads component The action bar is accessible only from within the upload itself Refs #3703
…f seeting directly in code Refs #3703
- Use the userId from the JWT as the one from the local storage can be manipulated Refs #3703
The column verified should be on the responses table Refs #3703
There was a problem hiding this comment.
@evansdianga Amazing work! The UI updates are well thought out and it works smoothly. A few comments:
- What are the trade offs of having the action bar vs not having it? Does it prevent the scrolling?
- After the 'verify' button is clicked, I think it should navigate back to the uploads table because it's a 'completion' action.
- Let's change the buttons from red to the default orange.
There was a problem hiding this comment.
Let's change the button colors to the default orange.
There was a problem hiding this comment.
Perfect. Will do so
There was a problem hiding this comment.
What made you decide to hide the action bar? If we can have both the scrolling and the action bar, I think it is helpful.
There was a problem hiding this comment.
My thoughts were that we needed to have the users review the document before changing the verified status.
And so would go for the edit.
Do you think there's a chance the users would choose to delete or verify a response without reviewing the form response?
There was a problem hiding this comment.
again, wondering why we are hiding the action bar
My thoughts were that we needed to have the users review the document before changing the verified status.
That's a good one. Will add the feature
Ok. Will update the PR with the fix |
… verifying a response After the 'verify' button is clicked, navigate back to the uploads table because it's a 'completion' action. Refs #3703
Description
Data editors should be able to verify uploaded form responses
Type of Change
Proposed Solution
Hide action bar when user is on group responses table
Add handler for
onRowClickAdd 3 sticky buttons to the group uploads form response view i.e.
Add the verified property as a column to the group responses table
Show the user a message with the result of the verification