-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListBox widget #32
base: master
Are you sure you want to change the base?
ListBox widget #32
Conversation
Bump. |
22 commits? Can't you squash them (at least yours) or something? 😕 |
|
It's easier to review changes when they are batched into fewer changesets. |
@binary1248 Can't you just look at the "Files changed" tab? |
I like to checkout the code locally and review it using my own tools. |
Ok, will do it. :) |
7ca7039
to
825b2aa
Compare
The commits are squashed (I did not squash Zax37 commit so that he still appears). |
Thanks for mentioning ;) |
a8939ec
to
57f63f0
Compare
Bump. I fixed a bug causing the scrollbar not to update when adding or removing items. |
Hi, Is there any desire to follow up on that PR? I have updated to recent master on my local fork. I'll be happy to help getting it merge, it is a really useful widget! One question though, is there any any reason this is not a list of Great job though, I tried it out in a toy project, and it works really well. |
I'm also waiting for this one :) |
This PR adds a
ListBox
widget. It's based on Zax37 but has almost been entirely rewritten to improve the widget.Features :
ListBox
Remarks ?
TODO: When you agreed on this implementation, write the doc (and squash the commits ?)